You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As #19 is merged we would like to propose some follow up changes to further improve embedding.
Configuration files/keys
Instead of storing the path to the file the bootstrap should contain the unmarshaled config struct. With this change the consumer can decide how the load/un-marshall the config during the boot-process (etcd, hard-coded, different format). This would also decouple the business-logic from any io which should also improve test-ability.
This will require some concept on how to add extension-points to the bootstrap. (Extend interface introduced in #19 ?)
Assets (index.html)
Similar as above but here the path to index.html would be replaced by an io.reader of to allow loading assets from an vfs or do some other processing. Identifier-webapp should be optional as it might be hosted on another server.
The text was updated successfully, but these errors were encountered:
As #19 is merged we would like to propose some follow up changes to further improve embedding.
Configuration files/keys
Instead of storing the path to the file the bootstrap should contain the unmarshaled config struct. With this change the consumer can decide how the load/un-marshall the config during the boot-process (etcd, hard-coded, different format). This would also decouple the business-logic from any io which should also improve test-ability.
This will require some concept on how to add extension-points to the bootstrap. (Extend interface introduced in #19 ?)
Assets (index.html)
Similar as above but here the path to index.html would be replaced by an io.reader of to allow loading assets from an vfs or do some other processing. Identifier-webapp should be optional as it might be hosted on another server.
The text was updated successfully, but these errors were encountered: