Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate or similar code #152

Open
BehindTheMath opened this issue Apr 19, 2020 · 1 comment
Open

Duplicate or similar code #152

BehindTheMath opened this issue Apr 19, 2020 · 1 comment

Comments

@BehindTheMath
Copy link
Contributor

BehindTheMath commented Apr 19, 2020 •
edited
Loading

A lot, if not all, of the code in GeoLocationUtils is duplicated in GeoLocation. One or the other can be removed.

Also, a lot of the geodesic code looks like it's not used at all.
@BehindTheMath
Copy link
Contributor Author

BehindTheMath commented Apr 19, 2020 •
edited
Loading

NOAACalculator.getSolarElevation() and NOAACalculator.getSolarAzimuth() are duplicates, besides for the last line.

NOAACalculator.getSunriseUTC() and NOAACalculator.getSunsetUTC() are also almost identical.

@BehindTheMath BehindTheMath changed the title Remove duplicate code from GeoLocation and GeoLocationUtils` Duplicate or similar code Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BehindTheMath