Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans on porting the lastest version to .NET? #167

Open
jasmh opened this issue Feb 4, 2021 · 10 comments
Open

Any plans on porting the lastest version to .NET? #167

jasmh opened this issue Feb 4, 2021 · 10 comments

Comments

@jasmh
Copy link

jasmh commented Feb 4, 2021

Thanks.

@BehindTheMath
Copy link
Contributor

There's already a .NET port:

https://github.com/Yitzchok/Zmanim

@jasmh
Copy link
Author

jasmh commented Feb 4, 2021

Yes, but the last version (1.5) vas ported 3 years ago and it's missing a lot that's been added since then.

@BehindTheMath
Copy link
Contributor

Feel free to open an issue on that repo. I don't maintain it.

@jasmh
Copy link
Author

jasmh commented Feb 5, 2021

I did, I thought you might have been connected somehow.

Thanks anyway.

@chacham2
Copy link

@jasmh I'm curious about the same thing. Did you find an options to move forward with?

Personally, i am interested in writing a Luach to display times and dedications. Considering the inactive development of the .net port, i'm thinking of using a jvm, like jni4net or ikvm.

@KosherJava
Copy link
Owner

@chacham2 and @jasmh There was recently some activity in the .NET port, and the author is hopeful to update it. They would gladly accept any PRs that would start bringing it up to date.

@chacham2
Copy link

chacham2 commented Apr 1, 2021

@KosherJava That project is neither complete nor up-to-date, so even if the port was finished, it would still likely lag behind this one. This afternoon, i was thinking that ikvm might be the best solution, and certainly ought to be the easiest.

That being said, ikvmc compiles the jar without issue, but it seems .net core is not working well, as evidenced by some reported issues (https://github.com/ikvm-revived/ikvm/issues). For the runtime i used the Windward version (https://www.nuget.org/packages/IKVM.WINDWARD) on NuGet. Tomorrow, i will likely try Framework instead.

@Yitzchok
Copy link

Yitzchok commented Apr 1, 2021

@chacham2 Not complete as in? Yes, it is not up-to-date and I can use the community help to get it there.

ikvm is not a clean solution to use java code in .NET you end up using way to many java namespaces in order to work with the java code which isn't optimal.

@chacham2
Copy link

chacham2 commented Apr 1, 2021

@Yitzchok I apologize: incomplete was an assumption based on the date and low usage.

it is not up-to-date and I can use the community help to get it there.

I will be frank and say upfront that i am not interested in helping with anything other than kudos. I applaud the effort, in any case.

While i am not qualified to comment on it overall, my own little mindset for my own little project is that the tradeoff will probably be worth the benefit of having the latest version of an actively maintained project. Then again, as i got nowhere today with my foray into unfamiliar territory, i might just be forced to revise that ill-formed opinion.

@chacham2
Copy link

chacham2 commented Apr 1, 2021

In case anyone else is interested, it works fine in ikvm using framework. Here is a simple example in vb winforms, where Name, Latitude, Longitude, and TimeZone are constants specified in another file:

Imports com.kosherjava.zmanim

Public Class Form1
    Private Sub Form1_Load(Sender As Object, Arguments As EventArgs) Handles MyBase.Load

        Dim Day As Date
        Dim Zmanim As New ZmanimCalendar(New util.GeoLocation(Name, Latitude, Longitude, java.util.TimeZone.getTimeZone(TimeZone)))

        For Offset As Integer = 0 To 3
            Day = Now.AddDays(Offset)
            Zmanim.getCalendar.set(Day.Year, Day.Month, Day.Day)
            Debug.WriteLine(Zmanim.getMinchaGedola)
            'Debug.WriteLine(Zmanim.toString())
        Next

        Close()
    End Sub
End Class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants