Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CRF input field is missing in videocombine node #339

Open
maxbizz opened this issue Dec 13, 2024 · 7 comments
Open

The CRF input field is missing in videocombine node #339

maxbizz opened this issue Dec 13, 2024 · 7 comments

Comments

@maxbizz
Copy link

maxbizz commented Dec 13, 2024

In my comfyui ,i cant find the CRF field in the videocombine node. I dont know whats gone wrong here. I have updated the nodes to the latest already

@maxbizz maxbizz changed the title The CRF filed is missing in videocombine node The CRF input field is missing in videocombine node Dec 13, 2024
@AustinMroz
Copy link
Collaborator

crf is only displayed if you have selected a format which that provides crf as an option (video/h264-mp4, video/h265-mp4, video/webm, and video/av1-webm)

@maxbizz
Copy link
Author

maxbizz commented Dec 14, 2024

Screenshot 2024-12-14 144525
I can confirm that this is not working. I have checked all the formats(video/h264-mp4, video/h265-mp4, video/webm). CRF field is still hidden. Many formats are also hidden like av1-webm,prores,8bit-png,16bit png etc.

@maxbizz
Copy link
Author

maxbizz commented Dec 14, 2024

Got this resolved. the h264 json file from another node is getting used instead of the json files inside videoformat folder of VHS node.

@FlareP1
Copy link

FlareP1 commented Dec 14, 2024

Thanks for this, I had the same problem, was driving me crazy. In my case the 'ComfyUI-tbox' node was overriding the settings. Is there anyway to ensure that the settings are only loaded from the ComfyUI-VideoHelperSuite directories ?

@maxbizz
Copy link
Author

maxbizz commented Dec 14, 2024

Yes, tthat's the same node creating the issue in my case as well..I just uninstalled that node.

@AustinMroz
Copy link
Collaborator

AustinMroz commented Dec 14, 2024

A conflicting node would have been in my next couple guesses of things to check, but I'm glad to hear you've figured it out.

ComfyUI-tbox has stolen code from VHS and violated the GPLv3 license it is under. It overrides the VHS_video_formats location, which is clearly namespaced to VHS, and leaves me with limited options.

I could no longer register video_formats as a folder path. This would remove the ability for users to specify an additional format location outside of VHS, but I'm not sure anyone has made use of such functionality.

EDIT: minor typo

@HIROKIxYUKI
Copy link

THANK YOU! this was driving me crazy, uninstalling ComfyUI-tbox worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants