Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Latent Video Preview is conflicting with preview in Queue window #345

Open
LukeG89 opened this issue Dec 22, 2024 · 1 comment
Open

[Bug]: Latent Video Preview is conflicting with preview in Queue window #345

LukeG89 opened this issue Dec 22, 2024 · 1 comment

Comments

@LukeG89
Copy link

LukeG89 commented Dec 22, 2024

Queue-Preview.mp4
@LukeG89 LukeG89 changed the title [Bug]: Latent Video Preview is coflicting with preview inside Queue window [Bug]: Latent Video Preview is conflicting with preview in Queue window Dec 22, 2024
@AustinMroz
Copy link
Collaborator

Thanks for the headsup. I had missed that this functionality was added.

It looks like I can make this work without any upstream changes by creating a new b_preview event that's not associated to any node 🤔, but I'll need to push for upstream changes anyways since the current queue implmentation has a memory leak.

AustinMroz added a commit that referenced this issue Dec 23, 2024
@AustinMroz
Attempted fix for queue previews.
f430c5a 
See #345

Send images in standard preview format, selectively allow propogation,
and prevent traditional image previews from displaying.

These changes seem to have poor performance and introduce strange edge
cases, so they will likely be dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AustinMroz @LukeG89