Add toString override and improve test coverage (#953)

Introduce a toString override in ColumnAccessorImpl to enhance debugging and readability. Added tests to verify exception behavior when a column is not found, ensuring stability and clarity in error messages.
Kotlin · Nov 18, 2024 · df464a6 · df464a6
1 parent 7695fb2
commit df464a6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/columns/ColumnAccessorImpl.kt b/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/columns/ColumnAccessorImpl.kt
@@ -43,4 +43,6 @@ internal class ColumnAccessorImpl<T>(val path: ColumnPath) : ColumnAccessor<T> {
     override fun getValue(row: AnyRow) = path.getValue(row) as T
 
     override fun getValueOrNull(row: AnyRow) = path.getValueOrNull(row) as T
+
+    override fun toString(): String = path().toString()
 }
diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/get.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/get.kt
@@ -49,6 +49,9 @@ class GetTests {
         shouldThrow<IllegalArgumentException> { row.getValue(c) }
         shouldThrow<IllegalArgumentException> { row.getValue(A::c) }
 
+        val throwable = shouldThrow<IllegalArgumentException> { df[column<Int>("c")] }
+        throwable.message shouldContain "Column not found: '[c]'"
+
         val added = df.add(A::c) { "3" }[0]
 
         shouldThrow<ClassCastException> { added.getValue(c) + 1 }