Skip to content

Commit

Permalink
- Create Scaled Drop Glyph and use for colour button and comboDrops
Browse files Browse the repository at this point in the history
- Remove the `PaletteRedirectDropDownButton`
- Remove `KryptonPaletteImagesDropDownButton`
- **Breaking Change**: Remove `DropDownButtonImages` from designers
- Correct usage spelling to `drop-down`

#1212
  • Loading branch information
Smurf-IV committed Dec 4, 2024
1 parent b15f035 commit cb3b704
Show file tree
Hide file tree
Showing 142 changed files with 449 additions and 1,503 deletions.
5 changes: 5 additions & 0 deletions Documents/Help/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
=======

# 2025-02-01 - Build 2502 (Patch 5) - February 2025
* Resolved [#1212](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1842), **[Breaking Change]** `KColorButton` 'drop-down' arrow should be drawn
- Create Scaled Drop Glyph and use for colour button and comboDrops
- Remove the `PaletteRedirectDropDownButton`
- Remove `KryptonPaletteImagesDropDownButton`
- **Breaking Change**: Remove `DropDownButtonImages` from designers
* Resolved [#1842](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1842), `KryptonTextBox` height collapses when MultiLine is enabled.
* Resolved [#1399](https://github.com/Krypton-Suite/Standard-Toolkit/issues/1399), Hard coded colour setting removed from the `KryptonRibbonTab`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public class KryptonNavigator : VisualSimple,
/// Occurs when the context action occurs.
/// </summary>
[Category(@"Navigator")]
[Description(@"Occurs when the drop down button is clicked in Outlook mode.")]
[Description(@"Occurs when the drop-down button is clicked in Outlook mode.")]
public event EventHandler<KryptonContextMenuEventArgs>? OutlookDropDown;

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public enum KryptonPageFlags
/// <summary>Specifies that the user is allowed to close a docking page.</summary>
DockingAllowClose = 0x0004,

/// <summary>Specifies that the user is allowed to select from a drop down button.</summary>
/// <summary>Specifies that the user is allowed to select from a drop-down button.</summary>
DockingAllowDropDown = 0x008,

/// <summary>Specifies that the user is allowed to make a page auto hidden.</summary>
Expand Down Expand Up @@ -501,7 +501,7 @@ public enum PaletteNavButtonSpecStyle
ArrowDown,

/// <summary>
/// Specifies a drop down button specification.
/// Specifies a drop-down button specification.
/// </summary>
DropDown,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,10 @@ public InheritBool HeaderSecondaryVisible

#region ShowDropDownButton
/// <summary>
/// Gets and sets the visibility of the drop down button on the Outlook overflow bar.
/// Gets and sets the visibility of the drop-down button on the Outlook overflow bar.
/// </summary>
[Category(@"Visuals")]
[Description(@"Visibility of the drop down button on the Outlook overflow bar.")]
[Description(@"Visibility of the drop-down button on the Outlook overflow bar.")]
[RefreshProperties(RefreshProperties.All)]
[DefaultValue(true)]
public bool ShowDropDownButton
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1726,7 +1726,7 @@ private void CreateButtonManager()
// Create a collection to hold button spec we want to display
_buttons = new OutlookButtonSpecCollection(Navigator);

// Create out drop down button specification
// Create out drop-down button specification
_specDropDown = new ButtonSpecAny
{
Type = PaletteButtonSpecStyle.DropDown,
Expand Down Expand Up @@ -1987,7 +1987,7 @@ private void ReorderCheckButtons()
Orientation buttonEdgeOrient = (stackOrient == Orientation.Vertical ? Orientation.Horizontal : Orientation.Vertical);
ViewDockStyle dockFar = (stackOrient == Orientation.Vertical ? ViewDockStyle.Bottom : ViewDockStyle.Right);

// Update the separator/drop down buttons with latest values
// Update the separator/drop-down buttons with latest values
_viewSeparatorEdge.Orientation = buttonEdgeOrient;
_viewSeparator.Orientation = buttonEdgeOrient;

Expand Down Expand Up @@ -2138,10 +2138,10 @@ private void OnDropDownClick(object sender, EventArgs e)
addRemoveButtonItems.Items.Add(pageMenuItem);
}

// Only enable the 'Add/Remove' if it has at least one drop down item
// Only enable the 'Add/Remove' if it has at least one drop-down item
addRemoveButtons.Enabled = (visibleAddRemove > 0);

// Get the display rectangle of the drop down button
// Get the display rectangle of the drop-down button
Rectangle rect = _buttonManager.GetButtonRectangle(_specDropDown);

// Convert to screen coordinates
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public void KeyTipSelect(KryptonRibbon ribbon)
// as this causes the tracking windows to be killed and we want them kept
ribbon.LostFocusLosesKeyboard = false;

// Get the target to show the drop down menu for the gallery
// Get the target to show the drop-down menu for the gallery
_target.KeyTipSelect();

// Exit the use of keyboard mode
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ internal class GroupButtonController : GlobalId,
public event MouseEventHandler? ContextClick;

/// <summary>
/// Occurs when a drop down portion is clicked.
/// Occurs when a drop-down portion is clicked.
/// </summary>
public event EventHandler? DropDown;
#endregion
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ public class KryptonGallery : VisualSimpleBase
public event EventHandler<ImageSelectEventArgs>? TrackingImage;

/// <summary>
/// Occurs when the user invokes the drop down menu.
/// Occurs when the user invokes the drop-down menu.
/// </summary>
[Category(@"Action")]
[Description(@"Occurs when user invokes the drop down menu.")]
[Description(@"Occurs when user invokes the drop-down menu.")]
public event EventHandler<GalleryDropMenuEventArgs>? GalleryDropMenu;
#endregion

Expand Down Expand Up @@ -199,10 +199,10 @@ public override bool AutoSize
}

/// <summary>
/// Gets the collection of drop down ranges.
/// Gets the collection of drop-down ranges.
/// </summary>
[Category(@"Visuals")]
[Description(@"Collection of drop down ranges")]
[Description(@"Collection of drop-down ranges")]
[MergableProperty(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Content)]
public KryptonGalleryRangeCollection DropButtonRanges { get; }
Expand Down Expand Up @@ -233,10 +233,10 @@ public Size PreferredItemSize
}

/// <summary>
/// Gets and sets the maximum number of lines items for the drop down menu.
/// Gets and sets the maximum number of lines items for the drop-down menu.
/// </summary>
[Category(@"Layout")]
[Description(@"Maximum number of line items for the drop down menu.")]
[Description(@"Maximum number of line items for the drop-down menu.")]
[DefaultValue(128)]
public int DropMaxItemWidth
{
Expand All @@ -253,10 +253,10 @@ public int DropMaxItemWidth
}

/// <summary>
/// Gets and sets the minimum number of lines items for the drop down menu.
/// Gets and sets the minimum number of lines items for the drop-down menu.
/// </summary>
[Category(@"Layout")]
[Description(@"Minimum number of line items for the drop down menu.")]
[Description(@"Minimum number of line items for the drop-down menu.")]
[DefaultValue(3)]
public int DropMinItemWidth
{
Expand Down Expand Up @@ -849,7 +849,7 @@ private void OnDropMenuClosed(object sender, ToolStripDropDownClosedEventArgs e)
{
if (_dropMenu != null)
{
// Remove any tracking caused by the drop down menu
// Remove any tracking caused by the drop-down menu
TrackingIndex = -1;

// Unhook from events
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
namespace Krypton.Ribbon
{
/// <summary>
/// Event arguments for the drop down menu of a gallery.
/// Event arguments for the drop-down menu of a gallery.
/// </summary>
public class GalleryDropMenuEventArgs : CancelEventArgs
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,12 @@ public enum GroupButtonType
Check,

/// <summary>
/// Specifies a button that when pressed shows a drop down.
/// Specifies a button that when pressed shows a drop-down.
/// </summary>
DropDown,

/// <summary>
/// Specifies a button that is split between push area and drop down area.
/// Specifies a button that is split between push area and drop-down area.
/// </summary>
Split
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ public class KryptonRibbonGroupButton : KryptonRibbonGroupItem
public event EventHandler? Click;

/// <summary>
/// Occurs when the drop down button type is pressed.
/// Occurs when the drop-down button type is pressed.
/// </summary>
[Category(@"Ribbon")]
[Description(@"Occurs when the drop down button type is pressed.")]
[Description(@"Occurs when the drop-down button type is pressed.")]
public event EventHandler<ContextMenuArgs>? DropDown;

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ public class KryptonRibbonGroupClusterButton : KryptonRibbonGroupItem
public event EventHandler? Click;

/// <summary>
/// Occurs when the drop down button type is pressed.
/// Occurs when the drop-down button type is pressed.
/// </summary>
[Category(@"Ribbon")]
[Description(@"Occurs when the drop down button type is pressed.")]
[Description(@"Occurs when the drop-down button type is pressed.")]
public event EventHandler<ContextMenuArgs>? DropDown;

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ public class KryptonRibbonGroupClusterColorButton : KryptonRibbonGroupItem
public event EventHandler? Click;

/// <summary>
/// Occurs when the drop down color button type is pressed.
/// Occurs when the drop-down color button type is pressed.
/// </summary>
[Category(@"Ribbon")]
[Description(@"Occurs when the drop down color button type is pressed.")]
[Description(@"Occurs when the drop-down color button type is pressed.")]
public event EventHandler<ContextMenuArgs>? DropDown;

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ public class KryptonRibbonGroupColorButton : KryptonRibbonGroupItem
public event EventHandler? Click;

/// <summary>
/// Occurs when the drop down color button type is pressed.
/// Occurs when the drop-down color button type is pressed.
/// </summary>
[Category(@"Ribbon")]
[Description(@"Occurs when the drop down color button type is pressed.")]
[Description(@"Occurs when the drop-down color button type is pressed.")]
public event EventHandler<ContextMenuArgs>? DropDown;

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,10 +498,10 @@ public ComboBoxStyle DropDownStyle
}

/// <summary>
/// Gets and sets the height, in pixels, of the drop down box in a KryptonComboBox.
/// Gets and sets the height, in pixels, of the drop-down box in a KryptonComboBox.
/// </summary>
[Category(@"Behavior")]
[Description(@"The height, in pixels, of the drop down box in a KryptonComboBox.")]
[Description(@"The height, in pixels, of the drop-down box in a KryptonComboBox.")]
[EditorBrowsable(EditorBrowsableState.Always)]
[DefaultValue(200)]
[Browsable(true)]
Expand All @@ -512,10 +512,10 @@ public int DropDownHeight
}

/// <summary>
/// Gets and sets the width, in pixels, of the drop down box in a KryptonComboBox.
/// Gets and sets the width, in pixels, of the drop-down box in a KryptonComboBox.
/// </summary>
[Category(@"Behavior")]
[Description(@"The width, in pixels, of the drop down box in a KryptonComboBox.")]
[Description(@"The width, in pixels, of the drop-down box in a KryptonComboBox.")]
[EditorBrowsable(EditorBrowsableState.Always)]
[DefaultValue(143)]
[Browsable(true)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,17 @@ public class KryptonRibbonGroupDateTimePicker : KryptonRibbonGroupItem
public event EventHandler? ValueNullableChanged;

/// <summary>
/// Occurs when the drop down is shown.
/// Occurs when the drop-down is shown.
/// </summary>
[Category(@"Action")]
[Description(@"Event raised when the drop down is shown.")]
[Description(@"Event raised when the drop-down is shown.")]
public event EventHandler<DateTimePickerDropArgs>? DropDown;

/// <summary>
/// Occurs when the drop down has been closed.
/// Occurs when the drop-down has been closed.
/// </summary>
[Category(@"Action")]
[Description(@"Event raised when the drop down has been closed.")]
[Description(@"Event raised when the drop-down has been closed.")]
public event EventHandler<DateTimePickerCloseArgs>? CloseUp;

/// <summary>
Expand Down Expand Up @@ -439,10 +439,10 @@ public Day CalendarFirstDayOfWeek
}

/// <summary>
/// Gets and sets if clicking the Today button closes the drop down menu.
/// Gets and sets if clicking the Today button closes the drop-down menu.
/// </summary>
[Category(@"MonthCalendar")]
[Description(@"Indicates if clicking the Today button closes the drop down menu.")]
[Description(@"Indicates if clicking the Today button closes the drop-down menu.")]
[DefaultValue(false)]
public bool CalendarCloseOnTodayClick
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ public class KryptonRibbonGroupGallery : KryptonRibbonGroupContainer
public event EventHandler<ImageSelectEventArgs>? TrackingImage;

/// <summary>
/// Occurs when the user invokes the drop down menu.
/// Occurs when the user invokes the drop-down menu.
/// </summary>
[Category(@"Action")]
[Description(@"Occurs when user invokes the drop down menu.")]
[Description(@"Occurs when user invokes the drop-down menu.")]
public event EventHandler<GalleryDropMenuEventArgs> GalleryDropMenu;

/// <summary>
Expand Down Expand Up @@ -158,10 +158,10 @@ public KryptonRibbonGroupGallery()
public KryptonGallery Gallery { get; }

/// <summary>
/// Gets the collection of drop down ranges.
/// Gets the collection of drop-down ranges.
/// </summary>
[Category(@"Visuals")]
[Description(@"Collection of drop down ranges")]
[Description(@"Collection of drop-down ranges")]
[MergableProperty(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Content)]
public KryptonGalleryRangeCollection DropButtonRanges => Gallery.DropButtonRanges;
Expand Down Expand Up @@ -298,10 +298,10 @@ public int DropButtonItemWidth
}

/// <summary>
/// Gets and sets the maximum number of lines items for the drop down menu.
/// Gets and sets the maximum number of lines items for the drop-down menu.
/// </summary>
[Category(@"Visuals")]
[Description(@"Maximum number of line items for the drop down menu.")]
[Description(@"Maximum number of line items for the drop-down menu.")]
[DefaultValue(128)]
public int DropMaxItemWidth
{
Expand All @@ -318,10 +318,10 @@ public int DropMaxItemWidth
}

/// <summary>
/// Gets and sets the minimum number of lines items for the drop down menu.
/// Gets and sets the minimum number of lines items for the drop-down menu.
/// </summary>
[Category(@"Visuals")]
[Description(@"Minimum number of line items for the drop down menu.")]
[Description(@"Minimum number of line items for the drop-down menu.")]
[DefaultValue(3)]
public int DropMinItemWidth
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ private void CreateMediumSmallButtonView()
// Create the layout docker for the contents of the button
var contentLayout = new ViewLayoutDocker();

// Create the image and drop down content
// Create the image and drop-down content
_viewMediumSmallImage = new ViewDrawRibbonGroupButtonImage(_ribbon, GroupButton, false);
_viewMediumSmallText1 = new ViewDrawRibbonGroupButtonText(_ribbon, GroupButton, true);
_viewMediumSmallText2 = new ViewDrawRibbonGroupButtonText(_ribbon, GroupButton, false);
Expand Down Expand Up @@ -500,7 +500,7 @@ private void UpdateDropDownState()
var dropDown = GroupButton.ButtonType == GroupButtonType.DropDown;
var splitButton = GroupButton.ButtonType == GroupButtonType.Split;

// Only show text line 2 separators is a drop down is showing with no text
// Only show text line 2 separators is a drop-down is showing with no text
var separators = (dropDown || splitButton) && (!string.IsNullOrEmpty(GroupButton.TextLine2));

// Update large view
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ internal class ViewDrawRibbonGroupButtonBackBorder : ViewComposite
public event MouseEventHandler? ContextClick;

/// <summary>
/// Occurs when the drop down button is clicked.
/// Occurs when the drop-down button is clicked.
/// </summary>
public event EventHandler? DropDown;
#endregion
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ private void CreateMediumSmallCheckBoxView()
// Create the layout docker for the contents of the button
_viewMediumSmall = new ViewLayoutRibbonCheckBox();

// Create the image and drop down content
// Create the image and drop-down content
_viewMediumSmallImage = new ViewDrawRibbonGroupCheckBoxImage(_ribbon, GroupCheckBox, false);
_viewMediumSmallText1 = new ViewDrawRibbonGroupCheckBoxText(_ribbon, GroupCheckBox, true);
_viewMediumSmallText2 = new ViewDrawRibbonGroupCheckBoxText(_ribbon, GroupCheckBox, false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ private void CreateView()
// Create the layout docker for the contents of the button
var contentLayout = new ViewLayoutDocker();

// Create the image and drop down content
// Create the image and drop-down content
_viewMediumSmallImage = new ViewDrawRibbonGroupClusterButtonImage(_ribbon, GroupClusterButton);
_viewMediumSmallText1 = new ViewDrawRibbonGroupClusterButtonText(_ribbon, GroupClusterButton)
{
Expand Down
Loading

0 comments on commit cb3b704

Please sign in to comment.