Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players changing view distance breaks SortedArraySet removeIf #49

Open
BomBardyGamer opened this issue Aug 10, 2021 · 1 comment
Open

Comments

@BomBardyGamer
Copy link
Member

Description

With the new chunk loading system, attempting to re-propagate a player with a different view distance can sometimes result in NullPointerExceptions from removeIf.

Do note, however, that this is not as simple as just properly null checking, as that will result in strange behaviour.

Steps to reproduce

Note: currently not reproducible, as per-player view distances are currently disabled due to this issue.

  1. Join the server with a set view distance
  2. Decrease the view distance
  3. Get kicked for internal exception

Expected behaviour

The removeIf operation removes all values matching the predicate, appropriately dealing with null values when they arise.

Details

  • Server version: Krypton 0.33
  • Java version: 16

Other information

N/A

@BomBardyGamer
Copy link
Member Author

This will get fixed when I drop the very broken ticket-based chunk propagation system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant