Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic form creation does not work #1

Open
JeroenTuinstra opened this issue Jun 3, 2021 · 2 comments · May be fixed by #2
Open

Automatic form creation does not work #1

JeroenTuinstra opened this issue Jun 3, 2021 · 2 comments · May be fixed by #2

Comments

@JeroenTuinstra
Copy link

When you fill everything in and click on "Générer mon attestation" it doesn't do anything except go back to the postal code field. As if the postal code is wrong even though there is a check mark next to it.
Basically the form doesn't get generated. Tried it on both Edge and Firefox, both same results.
@JeroenTuinstra
Copy link
Author

So basically there is an error in the form checking. It expects a 5 figures postal code. Yet postal codes in Belgium are only 4 digits long. This is just some poor programming as the form is for international travellers and their postal codes are not all the same size as the French.

akien-mga added a commit to akien-mga/attestation-honneur-ue that referenced this issue Jun 9, 2021
@akien-mga
Validation: Autoriser code postal de 4 chiffres
373667b 
Ce formulaire est a visé internationale et de nombreux pays utilisent des codes postaux
de plus ou moins de 5 chiffres. Le `minlength` et `maxlength` le confirment, mais la regex
de `pattern` force 5 chiffres.

Fixes LAB-MI#1.
@akien-mga akien-mga linked a pull request Jun 9, 2021 that will close this issue
Open
@akien-mga
Copy link

A workaround is to pad the number with a leading zero. #2 should fix the issue (needs testing by developers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validation: Autoriser code postal de 4 chiffres akien-mga/attestation-honneur-ue
2 participants
@akien-mga @JeroenTuinstra