Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In RGB genesis encode whole set of chain parameters, not just a network id/genesis hash #58

Closed
dr-orlovsky opened this issue Sep 22, 2020 · 1 comment
Closed

In RGB genesis encode whole set of chain parameters, not just a network id/genesis hash #58

dr-orlovsky opened this issue Sep 22, 2020 · 1 comment
Labels
enhancement New feature or request question Further information is requested [RGB] Specs related to client-validated state management system
Milestone
RGBv1

Comments

@dr-orlovsky
Copy link
Member

dr-orlovsky commented Sep 22, 2020 •
edited
Loading

RGB genesis must:

  • encode (with strict_encode) all chain parameters
  • commit (with commit_encode) only to network genesis block hash

This will allow clients to work with arbitrary networks, but change details of chain parameters (like default port numbers) over time without affecting commitments. Detailed chain parameters will work like a hint if the network parameters will be unknown for the client.

PR: LNP-BP/rust-lnpbp@cb0f1f5

Updt: LNP-BP/rust-lnpbp#114
@dr-orlovsky dr-orlovsky added enhancement New feature or request question Further information is requested [RGB] Specs related to client-validated state management system labels Sep 22, 2020
@dr-orlovsky dr-orlovsky added this to the RGB core: drafts milestone Sep 22, 2020
dr-orlovsky added a commit to LNP-BP/rust-lnpbp that referenced this issue Sep 22, 2020
@dr-orlovsky
Chain parameters in RGB genesis are not part of the commitment
cb0f1f5 
Implements <LNP-BP/LNPBPs#58>
@dr-orlovsky dr-orlovsky mentioned this issue Sep 22, 2020
Merged
@dr-orlovsky
Copy link
Member Author

Closing as implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested [RGB] Specs related to client-validated state management system
Projects
None yet
Milestone
RGBv1
Development

No branches or pull requests
1 participant
@dr-orlovsky