Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearly distinguish factored width from the tree width #183

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Clearly distinguish factored width from the tree width #183

merged 2 commits into from
Sep 4, 2024

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky self-assigned this Aug 20, 2024
@dr-orlovsky dr-orlovsky added the enhancement New feature or request label Aug 20, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Aug 20, 2024
@dr-orlovsky
Copy link
Member Author

@St333p so do you agree with the changes? This blocks the release cycle, we need to take a decision on whether to merge this PR ASAP

St333p
St333p approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@St333p St333p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on these changes, so I guess you can merge it

zoedberg
zoedberg reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't have a strong opinion on the changed code.

I'm not sure why Merklization.svg shows an incomplete tree while MPC.svg shows a complete one. I think that without a proper description of the images they are not very useful and could cause some doubts. Could you please clarify this and maybe explain the meaning of the graphs in the crate's README?

@dr-orlovsky
Copy link
Member Author

I'm not sure why Merklization.svg shows an incomplete tree while MPC.svg shows a complete one.

merklization.svg describes what merkle.rs module is doing, and MPC is what mpc module is doing - two different procedures.

Could you please clarify this and maybe explain the meaning of the graphs in the crate's README?

The graphs are not referenced and included in the README, I have to re-write it. I think this should be a dedicated PR unrelated to this one.

@zoedberg
Copy link
Member

zoedberg commented Sep 4, 2024

Ok, then this PR can be merged

@dr-orlovsky dr-orlovsky merged commit 25fb178 into master Sep 4, 2024
24 of 25 checks passed
@dr-orlovsky dr-orlovsky deleted the feat/factored-width branch October 12, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@St333p St333p St333p approved these changes

@zoedberg zoedberg zoedberg approved these changes

Assignees

@dr-orlovsky dr-orlovsky

Labels
enhancement New feature or request
Projects
Releases & roadmap
Status: Done
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dr-orlovsky @zoedberg @St333p