Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor telescope_names and telescope_sizes into a separate module #71

Open
drewoldag opened this issue Nov 1, 2024 · 0 comments
Open

Comments

@drewoldag
Copy link
Collaborator

There are several places in the code base where "telescope_name" is defined as a default input parameter like ['4m', '8m'] as well as "telescope_sizes" as [4, 8].

We should probably refactor that code, and pull those definition into a distinct module like "telescopes". And we should create it in such a way that it follows the open/closed principal.

At first though, it could be a simple dictionary in a telescopes.py module.

telescopes = {
    "4m": 4,
    "8m": 8
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant