Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skyCatalog test for object position test. #397

Open
cwwalter opened this issue Aug 3, 2023 · 1 comment
Open

Add skyCatalog test for object position test. #397

cwwalter opened this issue Aug 3, 2023 · 1 comment

Comments

@cwwalter
Copy link
Member

cwwalter commented Aug 3, 2023

Mike notes that currently, test_object_positions.py only is testing that things work with instance catalogs and that we should add tests for the skyCatalog case too.

Currently, he notes we are only checking if we can run a test in the sky catalogs by running the imsim-user-skycat.yaml file.

This issue is to figure out and then implement when we need to also make specific tests for all the different input cases.

@jchiang87
Copy link
Collaborator

The original motivation for the test_object_positions.py test was that we were finding that the rendered positions of stars didn't match the catalog positions for the LsstCamImSim instrument when using batoid ray-tracing. Ultimately, the cause of the problem was that the camera wasn't being specified consistently everywhere, i.e., the photon_ops code was always using LsstCam, even if LsstCamImSim was set in the config. In any case, the source of the object positions was not really relevant.

Re-running using a skycat input would test code that probably isn't being tested currently, but I think it would be better to write tests that address those code paths directly, e.g., tests that exercise InstCatWorldPos and SkyCatWorldPos, because that code (and what happens upstream) would be the relevant differences here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants