-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix half-light ratio value #77
Comments
After further discussion with Patricia it seems what we want are the cosmodc2 native quantities |
Could this fix wait for diffsky? |
Looking at this yet again, |
I just chatted with Patricia Larsen about the half-light radius convention that has been confusing for a while now. We ended up digging into the provenance of the hlr quantities all the way back up the chain.
It turns out that the quantities called
size_*_true
are actually the values we want for half-light-radius, and not the major axis, as it says in the GCR schema. So the line in skycatalogs where we computehlr = sqrt(a*b)
is not correct.should become simply
It also means that DC2 sizes were correct, and not too large by a factor of sqrt((1+e)/(1-e)) as we thought.
The text was updated successfully, but these errors were encountered: