Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Dataset: Dummy field with restriction with no value #6

Open
tilfischer opened this issue Feb 12, 2024 · 16 comments
Open

Generic Dataset: Dummy field with restriction with no value #6

tilfischer opened this issue Feb 12, 2024 · 16 comments
Assignees

Comments

@tilfischer
Copy link

Dear all,

Am I the first here? I am confused where to send the issue to. The other repos within this organisation do not allow issues.

Please check: ComPlat/chemotion_ELN#1748

Best,
Tillmann

@cllde8
Copy link
Member

cllde8 commented Feb 15, 2024

Hi @tilfischer

Thank you for selecting LabIMotion. I have created a template (using 'sample heating' as an example) for your review. Kindly examine it at http://193.196.38.92/ and provide us with your feedback.

screenshot-nimbusweb me-2024 02 15-16_56_51

Note: The account and password have been sent separately. As there are scientists concurrently working on their templates in the same instance, please exercise caution.

Thank you.

Best regards,
Claire

@cllde8 cllde8 self-assigned this Feb 15, 2024
@tilfischer
Copy link
Author

Thank you Claire!

The generic template for CV in the test instance got the working and enhanced dataset template from ComPlat/chemotion_ELN#1750. Thanks for adding this.

The page has the same limitation on restrictions to an field with empty value as shown in the video in ComPlat/chemotion_ELN#1748 if it is shown for the first time see:

brave_FSYalBXhTi.mp4

An workaround would be to have one layer for "sample preparation solvent" and "sample preparation supporting electrolyte" or... there is a way I am not aware of to have the supporting electrolyte (with controlled list) in the second line of sample preparation before selecting anything.

Best,
Tillmann

@cllde8
Copy link
Member

cllde8 commented Feb 15, 2024

Hi @tilfischer

I created the example using 'sample heating,' so the template will be displayed when the user selects 'sample heating' as the Type (Chemical Methods Ontology), not 'CV'. Please refer to the video at https://drive.google.com/file/d/1rHyez21NXRoqWXaMBE0UamgUJj_lM94_/view?usp=drive_link for clarification. If there are any misunderstandings, please don't hesitate to inform me.

Generic Dataset: sample heating / v0.2

Thank you.

Best regards,
Claire

@tilfischer
Copy link
Author

Dear Caire,

I tested this with "sample heating" but that gave the same result.

Best,
Tillmann

@cllde8
Copy link
Member

cllde8 commented Feb 16, 2024

Hi @tilfischer

I have prepared screenshots for various scenarios and would appreciate your feedback on each. Below are the details:

  • initialize

init-193 196 38 92-2024 02 16-15_14_14

  • H2O as Solvent

h2o-193 196 38 92-2024 02 16-15_15_32

  • others as Solvent

others-193 196 38 92-2024 02 16-15_16_04

  • clear (will be same as init)

clear-193 196 38 92-2024 02 16-15_16_26

  • others as Solvent, others as Supporting electrolyte

others+others-193 196 38 92-2024 02 16-15_21_52

@tilfischer
Copy link
Author

tilfischer commented Feb 17, 2024

Dear Claire,

thank you for the screenshots! Perhaps we have talked past each other. Screenshots 2, 3 and 5 show what I planned it should look like, but screenshots 1 and 4 are missing a dummy field between Concentration of analyte and Supporting electrolyte.

What I aimed for is shown above when H2O is selected as solvent also when no solvent is initially selected.

Field Restriction: when a restriction has been set, the field:(in layer:Sample preparation) is hidden, it shows only when the [Layer,Field,Value] got matched; if there are more than one setting, the field:(in layer:Sample preparation) shows when one of them got matched.

To have a dummy field shown if a solvent is selected, I added a dummy field with many restrictions for sample_preparation, solvent, <solvents_controlled_list>. If any of the solvents is selected, the dummy field is "shown" to the right side of "Concentration of Analyte" i.e. "Supporting electrolyte" appears at the next line.

If "other solvent" is selected, the field to specify the "other solvent" is shown, hence, the dummy field should be hidden, to not move this dummy field to the next line and start the next line with a dummy field. For this reason, sample_preparation, solvent, others was not added as restriction to the dummy field.

Then, I aimed for the same view as when any of the solvents is selected if no solvent is selected i.e. I added a restriction sample_preparation, solvent, with an empty field. This works, if I select e.g. H2O as solvent and then press the Xto delete the selection of H2O i.e. the field is emptied and the restriction applies.

However, this does not apply to the initial view, when no solvent was ever selected.

Best,
Tillmann

@cllde8
Copy link
Member

cllde8 commented Feb 20, 2024

Hi @tilfischer

Thank you for the detailed information. I've released a minor update, labeled as v0.3, for the "sample heating" template. Additionally, I've prepared a reference video at here for your convenience.

The key modification from version 0.2 to 0.3 focuses on the initial view (see screenshot). This version should align well with your requirements. Please give it a try and share your valuable feedback.

initial view
init-193 196 38 92-2024 02 20-13_02_41

instance: http://193.196.38.92/
generic dataset example: sample heating / v0.3

PS. While conducting my investigation, I identified an issue related to the view initialization. I've taken note of this and plan to address it in a future release. Thanks again.

Best regards,
Claire

@cllde8
Copy link
Member

cllde8 commented Feb 26, 2024

Hi @tilfischer

I've released v0.3 for the template, with the main change focusing on the initial view. Please try it and share feedback. If no further comments or feedback are forthcoming, I'll consider closing this ticket. Thank you.

Best,
Claire

@tilfischer
Copy link
Author

Dear Claire,

Sorry for the delayed response. I was on holidays, followed by a business trip but are back now. I checked your video and it looks as expected. I also tested in 193.196.38.92 and it looks as expected.

Diffing JSONs showed that changing

            "fields": [
                {
                    "type": "select",
                    "field": "solvent",
                    "label": "Solvent",
                    "default": "",
                    "position": 1,
                    "required": false,
                    "sub_fields": [],
                    "option_layers": "solvents",
                    "text_sub_fields": []
                },
...

to

            "fields": [
                {
                    "type": "select",
                    "field": "solvent",
                    "label": "Solvent",
                    "value": "",
                    "default": "",
                    "position": 1,
                    "required": false,
                    "sub_fields": [],
                    "option_layers": "solvents",
                    "text_sub_fields": []
                },
...

did the trick i.e. adding line "value": "",

Is is possible to add this line to the JSON via the generic designer UI or not yet?

The second (and last) place in the generic dataset template which would require such a line is under the section "Measurement details".

Video before:

brave_QyOTLUbBAD.mp4

Video after:

chrome_vJdpnVbRHl.mp4

Code snipped:

        "meas": {
            "wf": false,
            "key": "meas",
            "cols": 6,
            "color": "default",
            "label": "Measurement details",
            "style": "panel_generic_heading",
            "fields": [
                {
                    "type": "select",
                    "field": "reference_internal",
                    "label": "Internal reference",
                    "value": "",
                    "default": "",
                    "position": 1,
                    "required": false,
                    "sub_fields": [],
                    "option_layers": "reference_measure",
                    "text_sub_fields": []
                },
...
                {
                    "type": "dummy",
                    "field": "f4d5579c-8130-4c6b-9cc7-b9a0b308e476",
                    "label": "",
                    "default": "",
                    "position": 7,
                    "required": false,
                    "sub_fields": [],
                    "cond_fields": [
                        {
                            "id": "01a5b787-3b26-445d-afb3-821c98633d80",
                            "field": "reference_internal",
                            "layer": "meas",
                            "value": ""
                        }
                    ],
                    "text_sub_fields": []
                },
                {
                    "type": "dummy",
                    "field": "06f32e27-4fe5-4e8b-b249-a6cfaaa57fb9",
                    "position": 100,
                    "label": "",
                    "default": "",
                    "required": false,
                    "cond_fields": [
                        {
                            "layer": "meas",
                            "field": "reference_internal",
                            "value": "ferrocene",
                            "id": "2325f97f-5120-4675-bfdb-cfd7ca290c52"
                        },
                        {
                            "layer": "meas",
                            "field": "reference_internal",
                            "value": "decamethylferrocene",
                            "id": "6541ffb1-8cb2-4487-9114-3c4a99062e59"
                        },
                        {
                            "layer": "meas",
                            "field": "reference_internal",
                            "value": "none",
                            "id": "43c8d44f-f4f0-4db6-8239-e68843cf560f"
                        }
                    ]
                },
...

I added "value": "", in the field labeled "Internal reference" and a dummy field with restrictions to ferrocene, decamethylferrocene and none.

Looks perfect now. Could you also add this the the CV template currently under delopment. As soon as this is available on LabIMotion Hub, the group at Leipzig University would like to publish CV data in Chemotion Repository.

Best,
Tillmann

@cllde8
Copy link
Member

cllde8 commented Feb 28, 2024

Dear @tilfischer

I sincerely apologize for not being aware that you were on holiday, and I hope my message did not cause any inconvenience.

The requested changes have been implemented, and I've released the update to the Template Hub as version 0.3 of cyclic voltammetry (CV). Please feel free to share your feedback with us. If everything is functioning as expected, we can proceed to close this ticket. Thank you very much.

screenshot-www chemotion-repository net-2024 02 28-11_36_24

Best regards,
Claire

@tilfischer
Copy link
Author

No worries at all!

The issue with the CV-Template is solved. However, the "value": "", currently can not be added via the generic dataset template UI or have I simply missed this?

I would summarise that this issue and the corresponding issue ComPlat/chemotion_ELN#1748 can be closed if "value": "", can be added via the generic dataset template UI.

Best,
Tillmann

@cllde8
Copy link
Member

cllde8 commented Feb 29, 2024

Hi @tilfischer

Thank you for the reminder. I've replied at #6 (comment), mentioning that we will address it in a future release. Consequently, we'll keep this ticket open for now. Regarding the other issue, ComPlat/chemotion_ELN#1750, do you think we can close it?

Best regards,
Claire

@tilfischer
Copy link
Author

You are right. I have closed #6 with a comment linking to here.

Best,
Tillmann

@tilfischer
Copy link
Author

The devil.... Please compare the video in ComPlat/chemotion_ELN#1750 with the video on top of this issue for section "sample details" -> "amount". This field should be of Type: System-defined -> Mass, but possibly got lost by transfer tom #1750 to here and the template in the LabIMotion Hub.

Could you update this and push v0.4 to LabIMotion Hub?

@cllde8
Copy link
Member

cllde8 commented Feb 29, 2024

Hi @tilfischer

The template has been updated and released as v0.4.

screenshot-nimbusweb me-2024 02 29-13_31_02

Best regards,
Claire

@cllde8
Copy link
Member

cllde8 commented Apr 2, 2024

Dear @tilfischer,

We're pleased to inform you that a Preview of the upcoming LabIMotion is now available. This preview includes enhancements to the restriction settings, which we believe may address the view initialization topic you mentioned. You can find detailed information and a video here. We invite you to join this preview and explore the new additions in our test instance. Your feedback is invaluable to us, so please share your comments or suggestions in the Preview thread or related Discussions. Your contributions are sincerely appreciated.

Best regards,
Claire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants