Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copycat Headstocks of different styles do not attach #504

Closed
SeveringHams opened this issue Jul 18, 2024 · 1 comment
Closed

Copycat Headstocks of different styles do not attach #504

SeveringHams opened this issue Jul 18, 2024 · 1 comment
Labels
type: suggestion New feature or request

Comments

@SeveringHams
Copy link

Describe the Suggestion

I believe that replacing lines 97 and 116 of /content/buffer/headstock/CopycatHeadstockBlock.java from
BlockState toState = reader.getBlockState(toPos);
to
BlockState toState = reader.getBlockState(toPos).setValue(STYLE, state.getValue(STYLE));
would fix it.

As you could probably tell, it would make the methods isIgnoredConnectivitySide and canConnectTexturesToward pretend that the secondary headstock blockstate had the same STYLE value as the origin headstock blockstate.

Perhaps setting both state and toState's STYLE value to the same thing would to the same, and would reduce the amount of world accesses. Whatever you see to be most prudent, just my afterthought.

I don't care about credit, so if you think it would improve the mod at all, just chuck in the code.

Cheers!

Screenshots and Videos

No response

Additional Context

No response

@SeveringHams SeveringHams added the type: suggestion New feature or request label Jul 18, 2024
@SeveringHams
Copy link
Author

Wrong tag, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant