Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The README should list the major differences between WBI and WDI #464

Open
not-my-profile opened this issue Dec 5, 2022 · 5 comments
Open
Assignees

Comments

@not-my-profile
Copy link

Currently the WikibaseIntegrator / WikidataIntegrator section just refers the reader to the release notes ... however looking at them, these are all mostly minor details such as:

  • Create auto-assign-issue.yaml
  • Rename .yml to .yaml
  • Update README.md
  • Fix codespell errors

I am not even sure why any of these are listed in the release notes since such minor changes are not relevant/interesting to library users.

You have forked a library ... there are now two very similar looking libraries (if you're unfamiliar with either of them), so I think you should really describe the major differences/improvements in the README to clarify the situation.

@dpriskorn
Copy link
Contributor

I think that is a valid point. Have you found any differences?
Back when I selected it and started contributing I liked that it got lexeme support.

I have contributed ideas and the interface is now much more to my liking.

Perhaps it is better documented also?

@dpriskorn
Copy link
Contributor

WDI was/is? focused on Wikidata.
This functionality is not in WBI but seems very useful when you validating items. 😀image

@LeMyst
Copy link
Owner

LeMyst commented Dec 5, 2022

Hello @not-my-profile ,
Thank you for your comment.

I've updated the README to:

WikibaseIntegrator (wbi) is a fork of WikidataIntegrator (wdi) whose
purpose is to focus on an improved compatibility with Wikibase and adding missing functionalities.
The main differences between these two libraries are :

  • A complete rewrite of the library with an object-oriented architecture allowing for easy interaction, data validation
    and extended functionality
  • Add support for reading and writing Lexeme, MediaInfo and Property datatypes
  • Add support for Structured Data on Commons (SDC)
  • Python 3.7 to 3.11 suport, validated with unit tests
  • Type hints implementation for arguments and return
  • Improved login methods (OAuth 2.0, OAuth 1.0a, bot password and login/password)
  • Support for additionnal datatypes like EDTF and LocalMedia
  • Add logging module support

But WikibaseIntegrator lack to "fastrun" implemented in WikidataIntegrator.

@dpriskorn
Copy link
Contributor

FYI WDI also seems to have implemented EDTF support.

@not-my-profile
Copy link
Author

Thanks, I left some comments on your PR #466 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants