From c20697f0d712ed0ee6684ca276403e8046531074 Mon Sep 17 00:00:00 2001
From: Marcel Folaron <marcel.folaron@gmail.com>
Date: Thu, 21 Nov 2024 15:59:24 -0500
Subject: [PATCH] partial fix for project menu

---
 app/Core/Controller/Frontcontroller.php       |   2 +
 .../Menu/Hxcontrollers/ProjectSelector.php    |   2 +-
 .../includes/projectListFilter.blade.php      |  59 +++----
 .../projectSelectorDropdown.blade.php         | 164 +++++++++---------
 .../elements/leadingVisual.blade.php          |  10 +-
 .../components/forms/select/index.blade.php   |  30 ++--
 public/assets/less/components/select.css      |  50 ++++--
 7 files changed, 171 insertions(+), 146 deletions(-)

diff --git a/app/Core/Controller/Frontcontroller.php b/app/Core/Controller/Frontcontroller.php
index ac345e9116..6aa5378aa9 100644
--- a/app/Core/Controller/Frontcontroller.php
+++ b/app/Core/Controller/Frontcontroller.php
@@ -177,6 +177,8 @@ public function parseRequestParts(IncomingRequest $request)
     public function executeAction(string $controller, string $method): Response
     {
 
+        $this->incomingRequest->overrideGlobals();
+
         $parameters = $this->incomingRequest->getRequestParams();
 
         $controllerClass = app()->make($controller);
diff --git a/app/Domain/Menu/Hxcontrollers/ProjectSelector.php b/app/Domain/Menu/Hxcontrollers/ProjectSelector.php
index 63c7374cfe..52c6bb804f 100644
--- a/app/Domain/Menu/Hxcontrollers/ProjectSelector.php
+++ b/app/Domain/Menu/Hxcontrollers/ProjectSelector.php
@@ -34,7 +34,7 @@ public function init(Timesheets $timesheetService, Menu $menuService, \Leantime\
     /**
      * @throws BindingResolutionException
      */
-    public function updateMenu(): void
+    public function updateMenu($params): void
     {
 
         $allAssignedprojects =
diff --git a/app/Domain/Menu/Templates/includes/projectListFilter.blade.php b/app/Domain/Menu/Templates/includes/projectListFilter.blade.php
index 0d3c6fc722..1af0cae4cf 100644
--- a/app/Domain/Menu/Templates/includes/projectListFilter.blade.php
+++ b/app/Domain/Menu/Templates/includes/projectListFilter.blade.php
@@ -1,41 +1,42 @@
-<div class="projectListFilter">
+<div class="py-2">
 
-    <form hx-target="#mainProjectSelector" hx-swap="outerHTML" hx-trigger="change">
-        <i class="fas fa-filter"></i>
-        <x-global::forms.select data-placeholder="" title=""
-            hx-post="{{ BASE_URL }}/hx/menu/projectSelector/update-menu" hx-target="#mainProjectSelector"
-            hx-swap="outerHTML" hx-indicator=".htmx-indicator, .htmx-loaded-content" name="client">
-            <x-global::forms.select.select-option value="" data-placeholder="true">
-                All Clients
-            </x-global::forms.select.select-option>
+    <form hx-target="#mainProjectSelector" hx-swap="outerHTML" hx-trigger="change" hx-post="{{ BASE_URL }}/hx/menu/projectSelector/update-menu" hx-indicator=".project-loading-indicator">
 
-            @foreach ($clients as $client)
-                @if ($client['id'] > 0)
-                    <x-global::forms.select.select-option :value="$client['id']" :selected="isset($projectSelectFilter['client']) && $projectSelectFilter['client'] == $client['id']">
-                        {{ $client['name'] }}
-                    </x-global::forms.select.select-option>
-                @endif
-            @endforeach
-        </x-global::forms.select>
-
-        <i class="fa-solid fa-diagram-project"></i>
-
-        <x-global::forms.select data-placeholder="" name="groupBy"
-            hx-post="{{ BASE_URL }}/hx/menu/projectSelector/update-menu" hx-target="#mainProjectSelector"
-            hx-indicator=".htmx-indicator, .htmx-loaded-content" hx-swap="outerHTML">
-            @foreach ($projectSelectGroupOptions as $key => $group)
-                <x-global::forms.select.select-option :value="$key" :selected="$projectSelectFilter['groupBy'] == $key">
-                    {{ $group }}
+        <div class="flex flex-row justify-self-start">
+            <x-global::forms.select data-placeholder="" name="client">
+                <x-slot:leading-visual>
+                    <i class="fas fa-filter"></i>
+                </x-slot:leading-visual>
+                <x-global::forms.select.select-option value="" data-placeholder="true">
+                    All Clients
                 </x-global::forms.select.select-option>
-            @endforeach
-        </x-global::forms.select>
 
+                @foreach ($clients as $client)
+                    @if ($client['id'] > 0)
+                        <x-global::forms.select.select-option :value="$client['id']" :selected="isset($projectSelectFilter['client']) && $projectSelectFilter['client'] == $client['id']">
+                            {{ $client['name'] }}
+                        </x-global::forms.select.select-option>
+                    @endif
+                @endforeach
+            </x-global::forms.select>
+
+            <x-global::forms.select data-placeholder="" name="groupBy">
+                <x-slot:leading-visual>
+                    <i class="fa-solid fa-diagram-project"></i>
+                </x-slot:leading-visual>
+                @foreach ($projectSelectGroupOptions as $key => $group)
+                    <x-global::forms.select.select-option :value="$key" :selected="$projectSelectFilter['groupBy'] == $key">
+                        {{ $group }}
+                    </x-global::forms.select.select-option>
+                @endforeach
+            </x-global::forms.select>
+        </div>
         <input type="hidden" name="activeTab" value="" />
 
     </form>
 
 </div>
 
-<div class="htmx-indicator ml-m mr-m pt-l">
+<div class="project-loading-indicator htmx-indicator ml-m mr-m pt-l">
     <x-global::elements.loadingText type="project" count="5" includeHeadline="false" />
 </div>
diff --git a/app/Domain/Menu/Templates/includes/projectSelectorDropdown.blade.php b/app/Domain/Menu/Templates/includes/projectSelectorDropdown.blade.php
index 3417c81c35..49a25cf1fd 100644
--- a/app/Domain/Menu/Templates/includes/projectSelectorDropdown.blade.php
+++ b/app/Domain/Menu/Templates/includes/projectSelectorDropdown.blade.php
@@ -5,94 +5,100 @@
 
 <div class="dropdown-menu projectselector" id="mainProjectSelector">
 
-        @if ($menuType == 'project' || $menuType == 'default')
-            <div class="head">
-                <span class="sub">{{ __("menu.current_project") }}</span><br />
-                <span class="title">{{ session("currentProjectName") }}</span>
-            </div>
-        @else
-            <div class="projectSelectorFooter" style="border:none; border-bottom:1px solid var(--main-border-color)">
-            <ul class="selectorList projectList" hx-boost="true" hx-indicator="#global-loader">
-                <li>
-                    <a href="{{ BASE_URL }}/projects/showMy"><strong><i class="fa-solid fa-house-flag"></i> Open Project Hub</strong></a>
+    @if ($menuType == 'project' || $menuType == 'default')
+        <div class="head">
+            <span class="sub">{{ __("menu.current_project") }}</span><br />
+            <span class="title">{{ session("currentProjectName") }}</span>
+        </div>
+    @else
+        <div class="projectSelectorFooter" style="border:none; border-bottom:1px solid var(--main-border-color)">
+        <ul class="selectorList projectList" hx-boost="true" hx-indicator="#global-loader">
+            <li>
+                <a href="{{ BASE_URL }}/projects/showMy"><strong><i class="fa-solid fa-house-flag"></i> Open Project Hub</strong></a>
+            </li>
+
+            @if ($login::userIsAtLeast("manager"))
+                @dispatchEvent('beforeProjectCreateLink')
+                <li><a href="{{ $startSomethingUrl }}">
+                        <span class="fancyLink">
+                            {!! __('menu.create_something_new') !!}
+                        </span>
+                    </a>
                 </li>
+                @dispatchEvent('afterProjectCreateLink')
+            @endif
 
-                @if ($login::userIsAtLeast("manager"))
-                    @dispatchEvent('beforeProjectCreateLink')
-                    <li><a href="{{ $startSomethingUrl }}">
-                            <span class="fancyLink">
-                                {!! __('menu.create_something_new') !!}
-                            </span>
-                        </a>
-                    </li>
-                    @dispatchEvent('afterProjectCreateLink')
-                @endif
+        </ul>
+        </div>
+    @endif
 
-            </ul>
-            </div>
-        @endif
+    <x-global::content.tabs class="overflow-y-scroll max-h-[500px] border-b !border-b-gray-500">
+        <x-slot:headings>
+            <x-global::content.tabs.heading name="myProjects">{{ __('menu.projectselector.my_projects') }}</x-global::content.tabs.heading>
+            <x-global::content.tabs.heading name="favorites">{{ __('menu.projectselector.favorites') }}</x-global::content.tabs.heading>
+            <x-global::content.tabs.heading name="recent">{{ __('menu.projectselector.recent') }}</x-global::content.tabs.heading>
+            <x-global::content.tabs.heading name="allProjects">{{ __('menu.projectselector.all_projects') }}</x-global::content.tabs.heading>
+        </x-slot:headings>
+        <x-slot:contents>
+            <x-global::content.tabs.content name="myProjects" class="">
+                @include('menu::includes.projectListFilter', ['clients' => $clients, 'projectSelectFilter' => $projectSelectFilter])
+                <ul class="selectorList projectList htmx-loaded-content">
+                    @if($projectSelectFilter["groupBy"] == "client")
+                        @include('menu::includes.clientGroup', ['projects' => $allAssignedProjects, 'parent' => 0, 'level'=> 0, "prefix" => "myClientProjects", "currentProject"=>$currentProject])
+                    @elseif($projectSelectFilter["groupBy"] == "structure")
+                        @include('menu::includes.projectGroup', ['projects' => $projectHierarchy, 'parent' => 0, 'level'=> 0, "prefix" => "myProjects", "currentProject"=>$currentProject])
+                    @else
+                        @include('menu::includes.noGroup', ['projects' => $allAssignedProjects, "currentProject"=>$currentProject])
+                    @endif
+                </ul>
+            </x-global::content.tabs.content>
 
+            <x-global::content.tabs.content name="favorites" class="">
+                <ul class="selectorList projectList" hx-boost="true" hx-indicator="#global-loader">
+                    @if(count($favoriteProjects) >= 1)
+                        @include('menu::includes.noGroup', ['projects' => $favoriteProjects])
+                    @else
+                        <li><span class='info'>
+                        {{ __("text.you_have_not_favorited_any_projects") }}
+                        </span>
+                        </li>
+                    @endif
+                </ul>
+            </x-global::content.tabs.content>
 
-    <div class="tabbedwidget tab-primary projectSelectorTabs">
-        <ul class="tabs">
-            <li><a href="#myProjects">{{ __('menu.projectselector.my_projects') }}</a></li>
-            <li><a href="#favorites">{{ __('menu.projectselector.favorites') }}</a></li>
-            <li><a href="#recentProjects">{{ __('menu.projectselector.recent') }}</a></li>
-            <li><a href="#allProjects">{{ __('menu.projectselector.all_projects') }}</a></li>
-        </ul>
+            <x-global::content.tabs.content name="allProjects" class="">
+                @include('menu::includes.projectListFilter', ['clients' => $clients, 'projectSelectFilter' => $projectSelectFilter])
+                <ul class="selectorList projectList htmx-loaded-content"  hx-boost="true" hx-indicator="#global-loader">
+                    @if($projectSelectFilter["groupBy"] == "client")
+                        @include('menu::includes.clientGroup', ['projects' => $allAvailableProjects, 'parent' => 0, 'level'=> 0, "prefix" => "allClientProjects", "currentProject"=>$currentProject])
+                    @elseif($projectSelectFilter["groupBy"] == "structure")
+                        @include('menu::includes.projectGroup', ['projects' => $allAvailableProjectsHierarchy, 'parent' => 0, 'level'=> 0, "prefix" => "allProjects", "currentProject"=>$currentProject])
+                    @else
+                        @include('menu::includes.noGroup', ['projects' => $allAvailableProjects, "currentProject"=>$currentProject])
+                    @endif
+                </ul>
+            </x-global::content.tabs.content>
 
-        <div id="myProjects" class="scrollingTab">
-            @include('menu::includes.projectListFilter', ['clients' => $clients, 'projectSelectFilter' => $projectSelectFilter])
-            <ul class="selectorList projectList htmx-loaded-content">
-                @if($projectSelectFilter["groupBy"] == "client")
-                    @include('menu::includes.clientGroup', ['projects' => $allAssignedProjects, 'parent' => 0, 'level'=> 0, "prefix" => "myClientProjects", "currentProject"=>$currentProject])
-                @elseif($projectSelectFilter["groupBy"] == "structure")
-                    @include('menu::includes.projectGroup', ['projects' => $projectHierarchy, 'parent' => 0, 'level'=> 0, "prefix" => "myProjects", "currentProject"=>$currentProject])
-                @else
-                    @include('menu::includes.noGroup', ['projects' => $allAssignedProjects, "currentProject"=>$currentProject])
-                @endif
-            </ul>
-        </div>
-        <div id="allProjects" class="scrollingTab">
-            @include('menu::includes.projectListFilter', ['clients' => $clients, 'projectSelectFilter' => $projectSelectFilter])
-            <ul class="selectorList projectList htmx-loaded-content"  hx-boost="true" hx-indicator="#global-loader">
-                @if($projectSelectFilter["groupBy"] == "client")
-                    @include('menu::includes.clientGroup', ['projects' => $allAvailableProjects, 'parent' => 0, 'level'=> 0, "prefix" => "allClientProjects", "currentProject"=>$currentProject])
-                @elseif($projectSelectFilter["groupBy"] == "structure")
-                    @include('menu::includes.projectGroup', ['projects' => $allAvailableProjectsHierarchy, 'parent' => 0, 'level'=> 0, "prefix" => "allProjects", "currentProject"=>$currentProject])
-                @else
-                    @include('menu::includes.noGroup', ['projects' => $allAvailableProjects, "currentProject"=>$currentProject])
-                @endif
-            </ul>
-        </div>
-        <div id="recentProjects" class="scrollingTab">
-            <ul class="selectorList projectList" hx-boost="true" hx-indicator="#global-loader">
-                @if(count($recentProjects) >= 1)
-                    @include('menu::includes.noGroup', ['projects' => $recentProjects])
-                @else
-                    <li class='nav-header'></li>
-                    <li><span class='info'>
+            <x-global::content.tabs.content name="recent" class="">
+                <ul class="selectorList projectList" hx-boost="true" hx-indicator="#global-loader">
+                    @if(count($recentProjects) >= 1)
+                        @include('menu::includes.noGroup', ['projects' => $recentProjects])
+                    @else
+                        <li class='nav-header'></li>
+                        <li><span class='info'>
                         {{ __("menu.you_dont_have_projects") }}
                         </span>
-                    </li>
-                @endif
-            </ul>
-        </div>
-        <div id="favorites" class="scrollingTab">
-            <ul class="selectorList projectList" hx-boost="true" hx-indicator="#global-loader">
-                @if(count($favoriteProjects) >= 1)
-                    @include('menu::includes.noGroup', ['projects' => $favoriteProjects])
-                @else
-                    <li><span class='info'>
-                        {{ __("text.you_have_not_favorited_any_projects") }}
-                        </span>
-                    </li>
-                @endif
-            </ul>
-        </div>
-    </div>
+                        </li>
+                    @endif
+                </ul>
+            </x-global::content.tabs.content>
+
+        </x-slot:contents>
+    </x-global::content.tabs>
+
+
 
-            @if ($menuType == 'project' || $menuType == 'default')
+    @if ($menuType == 'project' || $menuType == 'default')
         <div class="projectSelectorFooter">
             <ul class="selectorList projectList" hx-boost="true" hx-indicator="#global-loader">
 
diff --git a/app/Views/Templates/components/elements/leadingVisual.blade.php b/app/Views/Templates/components/elements/leadingVisual.blade.php
index fcbec13bda..490fc46bb1 100644
--- a/app/Views/Templates/components/elements/leadingVisual.blade.php
+++ b/app/Views/Templates/components/elements/leadingVisual.blade.php
@@ -2,8 +2,8 @@
     'leadingVisual' => ''
 ])
 
-@if($leadingVisual)
-    <span class="absolute inset-y-0 left-0 pl-3 flex items-center pointer-events-none">
-        {!! $leadingVisual !!}
-    </span>
-@endif
+
+<span class="absolute inset-y-0 left-0 pl-3 flex items-center pointer-events-none">
+    {!! $slot !!}
+</span>
+
diff --git a/app/Views/Templates/components/forms/select/index.blade.php b/app/Views/Templates/components/forms/select/index.blade.php
index 92e0a21c4e..bed391fde6 100644
--- a/app/Views/Templates/components/forms/select/index.blade.php
+++ b/app/Views/Templates/components/forms/select/index.blade.php
@@ -20,7 +20,8 @@
     'autocompleteTags' => false,
     'formHash' => md5(CURRENT_URL."selectChoices".mt_rand(0,100)),
     'value' => '',
-    'maxItemCount' => ''
+    'maxItemCount' => '',
+    'name' => '',
 ])
 
 @php
@@ -79,18 +80,21 @@
     @endif
 
     <div {{$attributes->merge(['class' => ($variant === 'tags' ? 'tags inline-block w-full' : '')])}} >
-        @if($leadingVisual)
-            <span class="absolute inset-y-0 left-0 pl-3 flex items-center pointer-events-none">
-                {{ $leadingVisual }}>
-            </span>
-        @endif
-
-        <select
-            {{$attributes->merge(['class' => $selectClassBuilder ])}}
-            {{ $state === 'disabled' ? 'disabled' : '' }}
-            {{ $variant === 'multiple' || $variant === 'tags' ? 'multiple' : '' }}>
-            {{ $slot }}
-        </select>
+        <div class="flex flex-row">
+            @if($leadingVisual)
+                <x-global::elements.leadingVisual>
+                    {{ $leadingVisual }}
+                </x-global::elements.leadingVisual>
+            @endif
+
+            <select
+                {{$attributes->merge(['class' => $selectClassBuilder ])}}
+                name="{{ $name }}"
+                {{ $state === 'disabled' ? 'disabled' : '' }}
+                {{ $variant === 'multiple' || $variant === 'tags' ? 'multiple' : '' }}>
+                {{ $slot }}
+            </select>
+        </div>
 
     </div>
 
diff --git a/public/assets/less/components/select.css b/public/assets/less/components/select.css
index a6c51b9682..92d87d81f6 100644
--- a/public/assets/less/components/select.css
+++ b/public/assets/less/components/select.css
@@ -11,7 +11,7 @@
     }
 
    &.select-chip {
-       @apply bg-none leading-6 min-h-6 h-6 w-auto px-0.5 rounded-full ps-1.5 pe-1.5 bg-none text-xs leading-6 min-h-6 h-6 align-sub;
+       @apply bg-none leading-6 min-h-6 h-6 w-auto px-0.5 rounded-full ps-1.5 pe-1.5 text-xs align-sub;
 
        .choices__inner {
             margin-top:2px;
@@ -49,6 +49,8 @@
     select {
         display: none;
     }
+
+    overflow:hidden;
 }
 
 .select.is-open {
@@ -154,7 +156,6 @@
 .choices__inner {
     display: inline-block;
     width: 100%;
-    overflow-y:auto;
 }
 .is-focused .choices__inner, .is-open .choices__inner {}
 .is-open .choices__inner {}
@@ -168,16 +169,23 @@
 /* Single Selected Choices Item */
 .choices__list--single {
     display: inline-block;
-}
 
-[dir=rtl] .choices__list--single {}
+    .choices__item {
+
+        width: 100%;
+        align-content: center;
+        @apply px-0 text-sm select-sm;
+
+        .choices__button {
+            display:none;
+        }
+
+    }
 
-.choices__list--single .choices__item {
-    width: 100%;
-    align-content: center;
-    @apply px-0 text-sm select-sm;
 }
 
+[dir=rtl] .choices__list--single {}
+
 .select-chip {
     .choices__list--single .choices__item {
         @apply text-xs leading-5 min-h-5 h-5;
@@ -190,14 +198,20 @@
 
 .choices__list--multiple {
     display: inline;
-}
-.choices__list--multiple .choices__item {
-    @apply bg-primary text-primary-content p-1 px-2 text-xs mr-1;
-    display: inline-block;
-    vertical-align: middle;
-    border-radius: 1rem;
-    word-break: break-all;
-    box-sizing: border-box;
+
+    .choices__item {
+        @apply bg-primary text-primary-content p-1 px-2 text-xs mr-1;
+        display: inline-block;
+        vertical-align: middle;
+        border-radius: 1rem;
+        word-break: break-all;
+        box-sizing: border-box;
+
+        .is-highlighted {
+            @apply bg-primary;
+        }
+    }
+
 }
 .choices__list--multiple .choices__item[data-deletable] {
 }
@@ -206,9 +220,7 @@
     margin-right: 0;
     margin-left: 3.75px;
 }
-.choices__list--multiple .choices__item.is-highlighted {
-    @apply bg-primary;
-}
+.choices__list--multiple .choices__item
 .is-disabled .choices__list--multiple .choices__item {
     @apply bg-neutral;
 }