Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA] Removing checks when broadcast is disabled #8662

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[QAA] Removing checks when broadcast is disabled #8662

merged 1 commit into from
Dec 11, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Dec 10, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Removing checks when broadcast is disabled

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Dec 11, 2024 10:46am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 10:46am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 10:46am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 10:46am

@VicAlbr VicAlbr marked this pull request as ready for review December 10, 2024 15:16
@VicAlbr VicAlbr requested review from a team as code owners December 10, 2024 15:16
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 10, 2024
@VicAlbr VicAlbr force-pushed the support/update-operations-checks branch from d6e084a to 98eceec Compare December 11, 2024 08:52
@live-github-bot live-github-bot bot added the common Has changes in live-common label Dec 11, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 11, 2024 •
edited
Loading

Mobile Bundle Checks

Comparing 5b7f08d against 96ce12d.

✅ Previous issues have all been fixed.

Desktop Bundle Checks

Comparing 5b7f08d against 1e60d96.

✅ Previous issues have all been fixed.

@VicAlbr VicAlbr force-pushed the support/update-operations-checks branch from 98eceec to 58ebe7a Compare December 11, 2024 09:04
@VicAlbr VicAlbr force-pushed the support/update-operations-checks branch from 58ebe7a to 0c14853 Compare December 11, 2024 09:27
@VicAlbr VicAlbr force-pushed the support/update-operations-checks branch from 0c14853 to 1edbecb Compare December 11, 2024 10:40
@VicAlbr VicAlbr merged commit 23bb5d6 into develop Dec 11, 2024
54 of 55 checks passed
@VicAlbr VicAlbr deleted the support/update-operations-checks branch December 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharamboure-ledger bharamboure-ledger bharamboure-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@LucasWerey LucasWerey LucasWerey approved these changes

Assignees

@VicAlbr VicAlbr

Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VicAlbr @LucasWerey @ypolishchuk-ledger @bharamboure-ledger