Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fweo 1254 pinpad nano #832

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fweo 1254 pinpad nano #832

merged 2 commits into from
Dec 10, 2024

Conversation

jarevalo-ledger
Copy link
Contributor

@jarevalo-ledger jarevalo-ledger commented Dec 9, 2024

Description

Fix pin keypad behavior to pre-nbgl.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Stay on backspace key until there is a PIN entry to delete
Only shuffle digits, backspace and validate keys must not be selected
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (e8f68a6) to head (823c5ca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files          13       13           
  Lines        1606     1606           
=======================================
  Hits          570      570           
  Misses       1036     1036           
Flag Coverage Δ
unittests 35.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jarevalo-ledger jarevalo-ledger merged commit 751547a into master Dec 10, 2024
188 checks passed
@jarevalo-ledger jarevalo-ledger deleted the fweo-1254-pinpad-nano branch December 10, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants