-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve project structure #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecatcore
changed the title
Improve project structure + Update Loom, Gradle and dependencies
Improve project structure
Feb 8, 2024
Ready for review |
BluCobalt
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structure changes:
Example for
legacy-fabric-registry-sync-api-v1
:Previously
Split into
common/legacy-fabric-registry-sync-api-v1
,1.8.9/legacy-fabric-registry-sync-api-v1
,1.7.10/legacy-fabric-registry-sync-api-v1
,1.8/legacy-fabric-registry-sync-api-v1
,1.9.4/legacy-fabric-registry-sync-api-v1
1.10.2/legacy-fabric-registry-sync-api-v1
,1.12.2/legacy-fabric-registry-sync-api-v1
.Each declares its dependencies individually in the subproject build.gradle.
Supported version range is hardcoded in fabric.mod.json.
1.10.2/legacy-fabric-registry-sync-api-v1/build.gradle
1.10.2/legacy-fabric-registry-sync-api-v1/src/main/resources/fabric.mod.json
Now
Split into
legacy-fabric-registry-sync-api-v1/common
,legacy-fabric-registry-sync-api-v1/1.7.10
,legacy-fabric-registry-sync-api-v1/1.8
,legacy-fabric-registry-sync-api-v1/1.8.9
,legacy-fabric-registry-sync-api-v1/1.9.4
,legacy-fabric-registry-sync-api-v1/1.10.2
,legacy-fabric-registry-sync-api-v1/1.12.2
.A common
build.gradle
file inlegacy-fabric-registry-sync-api-v1
to declare module dependencies, version specific dependencies are inferred from it.If additional dependencies are needed declare them in the submodule
build.gradle
.Each submodule contains a
gradle.properties
file, containing informations related to the support mc version range, which will be used when inferring module dependencies.legacy-fabric-registry-sync-api-v1/build.gradle
legacy-fabric-registry-sync-api-v1/1.10.2/build.gradle
// Nothing
legacy-fabric-registry-sync-api-v1/1.10.2/gradle.properties
legacy-fabric-registry-sync-api-v1/1.10.2/src/main/resources/fabric.mod.json