Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- issues #1 and #2 fixed #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

- issues #1 and #2 fixed #6

wants to merge 6 commits into from

Commits on Dec 16, 2014

  1. - issues LegendarySolutions#1 and LegendarySolutions#2 fixed 

    - entire project refactored a bit
- unit tests for payment servlet created
- several validators invented
- existing unit tests fixed
    @cendrowiczm
    cendrowiczm committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    e8d780a View commit details
    Browse the repository at this point in the history

  2. SUT is not a mock and veryfing its method calls doesn't make sense an… 

    …d won't work
    @cendrowiczm
    cendrowiczm committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    3c383a1 View commit details
    Browse the repository at this point in the history

  3. Velocity templates for all order notifications

    @cendrowiczm
    cendrowiczm committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    ecb4116 View commit details
    Browse the repository at this point in the history

  4. + more generic way to create notifications - EMail Service refactored 

    + fixed template for paid order
+ added test that covers scenario for completion of paid order
    @cendrowiczm
    cendrowiczm committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    20ac270 View commit details
    Browse the repository at this point in the history

  5. Fixed all tests where the response is mock'ed (weird NPEs eliminated!)

    @cendrowiczm
    cendrowiczm committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    f06d536 View commit details
    Browse the repository at this point in the history

  6. Tests assert that system sends out correct notifications (:))

    @cendrowiczm
    cendrowiczm committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    6309974 View commit details
    Browse the repository at this point in the history