Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to fetch multiple comments from modlog by ids #5232

Open
5 tasks done
aeharding opened this issue Nov 27, 2024 · 11 comments
Open
5 tasks done

Provide a way to fetch multiple comments from modlog by ids #5232

aeharding opened this issue Nov 27, 2024 · 11 comments
Labels
area: moderation enhancement New feature or request

Comments

@aeharding
Copy link

Requirements

  • Is this a feature request? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a feature request? Do not put multiple feature requests in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.
  • Do you agree to follow the rules in our Code of Conduct?

Is your proposal related to a problem?

This issue stems from #5230. Essentially, I want to allow mods to view removed comments in a thread view. Since Lemmy removed the comment content for mods, I have to fetch each comment view the mod log with a separate request. This is very inefficient, and it would be nice to provide a way to bulk fetch comments in the modlog by id.

This issue is important for mods because right now if a mod nukes a chain, it's really annoying to have to step through the chain and view the mod log for each comment just in order to view the comment content.

Describe the solution you'd like.

Bulk fetch comments in modlog by id

Describe alternatives you've considered.

The alternative, as per #5230 (and old lemmy behavior) is to provide the comment content when fetching a comment thread for mods.

Additional context

No response

@aeharding aeharding added the enhancement New feature or request label Nov 27, 2024
@dessalines
Copy link
Member

Why not just have a show removed comment button for each one, and have it fetch on demand, and fill the comment box with the most recent removed content? Seems really inefficient to try to collect up all the removed ids for an entire thread, use a SQL in query to get them, then iterate through every response.

That's also not too ideal anyway, since its not going to show you the full history for that item.

@aeharding
Copy link
Author

One example: It allows mods to go through and selectively approve comments after nuking a comment thread.

0clicks vs 20+ for large nukes (and more if you accidentally refresh…)

Also it’s much easier for mods to audit another mods bulk comment removal actions

@aeharding
Copy link
Author

That's also not too ideal anyway, since its not going to show you the full history for that item.

yah agreed. That’s why I prefer old Lemmy behavior, where comment content of removed comments is available for mods on original request. In lieu of that, though…

@DraconicNEO
Copy link

Why not just have a show removed comment button for each one, and have it fetch on demand, and fill the comment box with the most recent removed content? Seems really inefficient to try to collect up all the removed ids for an entire thread, use a SQL in query to get them, then iterate through every response.

That's also not too ideal anyway, since its not going to show you the full history for that item.

I think that's a good idea, just being able to reveal removed comments is a good thing for being able to see context in a removed thread. Probably also a good idea for the ones which were removed silently without modlog posts, which is the case with ones removed automatically alongside a ban.

@MrKaplan-lw
Copy link

To be honest, this is one of the main issues we currently still have with upgrading.
Right now, I'm using a userscript to reveal deleted comments again, but it can also be done with photon without a userscript, which also makes it more accessible to community mods.
We will at the very least be applying a patch to revert this behavior for admins. We haven't decided on rolling this back entirely yet or looked at the complexity of checking whether the person is a moderator, but I know of several mods that are using this from time to time.

@aeharding
Copy link
Author

Probably also a good idea for the ones which were removed silently without modlog posts, which is the case with ones removed automatically alongside a ban.

I thought that was fixed recently. #4699

@DraconicNEO
Copy link

Probably also a good idea for the ones which were removed silently without modlog posts, which is the case with ones removed automatically alongside a ban.

I thought that was fixed recently. #4699

I'm not sure, if it has I'm not seeing the effects of it. I don't think it has though since I'm still not able to see them on any of my servers.

@Nutomic
Copy link
Member

Nutomic commented Dec 2, 2024

It would actually be pretty easy to return the content of removed comments only for admins. I made a PR for that in #5245. It doesnt mean that lemmy-ui will support this, so you may have to use different frontends or user scripts. It would also be much more complicated to do the same thing for mods (as each returned comment may belong to a different community).

@aeharding
Copy link
Author

@Nutomic thanks that's awesome!

Regarding showing content for mods, would that be easier once #4365 is completed?

dessalines pushed a commit that referenced this issue Dec 2, 2024
* Return content of removed comments for admins (ref #5232)

* fmt

* remove dbg
@dessalines
Copy link
Member

dessalines commented Dec 2, 2024

Yes it would be, although it will be a while before I can get to that, although it is a priority for 0.20.0

@aeharding
Copy link
Author

aeharding commented Dec 2, 2024

@dessalines awesome. I can close this issue and open a new one to address showing removed comment content for mods, with a note that it is blocked until #4365 is done.

Edit: Or that could just be a subtask of #4365.

LMK what is preferred!

Nutomic added a commit that referenced this issue Dec 3, 2024
* Return content of removed comments for admins (ref #5232)

* fmt

* remove dbg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: moderation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants