Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from users #8

Open
LeonardoGentile opened this issue Jun 11, 2018 · 3 comments
Open

Feedback from users #8

LeonardoGentile opened this issue Jun 11, 2018 · 3 comments

Comments

@LeonardoGentile
Copy link
Owner

LeonardoGentile commented Jun 11, 2018

Hello mates!
This little project of mine started to solve a personal problem but it turns out other people are using it ;)

I'd like to have a little feedback if you have a couple of minutes:

  1. How/where are you using this? (big/small apps, personal projects?)
  2. Are you using the getComponent or RouteView utilities or using a plain ol' switch?
  3. Is the README too complex to follow? Do you think it could be simplified?

Thanks!

@micros123
Copy link

micros123 commented Jun 18, 2018

Hi Leonardo,
I'm trying to switch a big project over from React-Router v4 to Router5. So far I'm using switch, but may try the utils once I get my head wrapped around Router5 more.
My most important request would be: Please create a basic example project. A ToDo App or something even simpler, and apply all best practices. Maybe two alternative versions using different design patterns. That would make understanding Router5 with your MobX/React integration so much easier to follow than just docs.

@LeonardoGentile
Copy link
Owner Author

@micros123 thanks for your feedback

Why are moving away from React-Router v4? Wondering if others have the same reasons :]

Have you checked https://github.com/LeonardoGentile/react-mobx-router5-example? Surely it's not a complex and in-depth example, I've been planning something more serious for a while, I just need some time

@micros123
Copy link

Two main reasons:

  1. Making API calls based on route changes requires a lot of custom code.
  2. The bad handling of transitions. I tried AnimatedSwitch. But I still sometimes see two states at the same time, then one disappears, making the page very jumpy.

I'll have a look at your example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants