-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alex/implement email notification functionality #464
base: develop
Are you sure you want to change the base?
Alex/implement email notification functionality #464
Conversation
…ted imports alphabetically
…Technical/gridiron-survivor into ryan/create-admin-layout
… declared in the layout but the props can be updated per page
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…nality" and "origin/alex/implement-email-notification-functionality" Fix: Deleted userIDs from function to avoid getting spammed
…for bcc emailing.
…he league info and then grab the targetIDs of the users.
…il-notification-functionality
textAreaRef.style.height = `${scrollHeight + offsetBorder}px`; | ||
} | ||
} | ||
}, [textAreaRef, triggerAutoSize]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when we remove textAreaRef and/or triggerAutoSize from useEffect dependencies here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't need to re-render the component, this will cause unnecessary re-renders.
if (textAreaRef) { | ||
if (init) { | ||
textAreaRef.style.minHeight = `${minHeight + offsetBorder}px`; | ||
if (maxHeight > minHeight) { | ||
textAreaRef.style.maxHeight = `${maxHeight}px`; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these if statement nestings necessary, or are there ways we can combine some of them into one if conditional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a question for Ryan. These were his changes made that got merged into my branch after approval.
…il-notification-functionality
…il-notification-functionality
textAreaRef.style.height = `${scrollHeight + offsetBorder}px`; | ||
} | ||
} | ||
}, [textAreaRef, triggerAutoSize]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't need to re-render the component, this will cause unnecessary re-renders.
*/ | ||
const getLeagueData = async (): Promise<void> => { | ||
try { | ||
const leagueId = '66f1a8e300102bff03ff'; // EMAIL TEST LEAGUE (DO NOT CHANGE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not have this dynamically working?
* Fetches the league data. | ||
* @returns The league data. | ||
*/ | ||
const fetchData = async (): Promise<void> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be in a useEfect or can it just be called when the component mounts?
Closes #463
Create functionality for email notifications into the project for the admin notifications page.
ONCE this ticket gets merged in, I will create more tickets to implement more customization for sending emails. Ex: survivors only email, eliminated. For now, only participants is created to test that the email function does take in id's and sends an email.
Recording.2024-08-19.143407.mp4