clue/FEE: Implement User and Admin Menu Dropdowns #392 #487
Conversation
|
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Clue355
requested review from
emestabillo,
ryandotfurrer,
jennifertieu,
FurrerW,
choir241,
ramblingadam,
vmaineng,
chris-nowicki,
jasonetorres,
CorinaMurg and
alexappleget
| await logoutAccount(); | ||
| router.push('/login'); | ||
| } catch (error) { | ||
| throw new Error('Logout failed'); |
There was a problem hiding this comment.
Update to this code so it will throw the actual error and not a made up string.
| throw new Error('Logout failed'); | |
| throw error; |
| </DropdownMenuItem> | ||
| <DropdownMenuItem className="cursor-pointer rounded-none focus:bg-muted"> | ||
| <Button | ||
| className="w-full text-base no-underline py-2 px-0 h-auto text-muted-foreground hover:text-foreground font-normal justify-normal hover:underline" |
There was a problem hiding this comment.
Is this a special button that it needs all these different class names? @ryandotfurrer Can we create a new variant for this type of button so we're not setting these classes over again?
There was a problem hiding this comment.
Hey @shashilo, By default, shadcn uses a different look that I needed to change to match our design (first screenshot). Shadcn's does not take up the full width (second screenshot).
I reckon we could call this variant something like "DropdownMenuToggleButton" or something along those lines to describe what it should be used for.
Figma design
shadcn default
There was a problem hiding this comment.
Let's do that, but in another ticket.
shashilo
requested review from
alexappleget,
vmaineng,
choir241 and
ryandotfurrer
Feat: