Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: 大部分弹窗控件的背景色应该可以配置,而不是写死为白色 #356

Open
lvyandev opened this issue Oct 13, 2022 · 1 comment
Assignees

Comments

@lvyandev
Copy link

lvyandev commented Oct 13, 2022

功能需求

如题
在提功能需求之前,建议先查询组件文档,考虑你需要的功能是否可以通过组件其他属性完成。如无法解决 ,issue 参考:

标题格式:[Feature]: 需求描述
发现一些控件的背景色无法被控制,建议检查一下所有的弹窗widget的背景色是不是写死为Colors.white,目前看到的有BrnCommonActionSheet BrnSelectionMenuWidget,这样就没办法适配深色主题,希望可以做成可配置或者跟随系统背景色

return GestureDetector(
      child: Container(
          decoration: ShapeDecoration(
           // 应该在themeData添加可配置的背景色,或者使用commonConfig或者dialogConfig的背景色
            color: Colors.white,
            shape: RoundedRectangleBorder(
              borderRadius: BorderRadius.only(
                topLeft: Radius.circular(themeData!.topRadius),
                topRight: Radius.circular(themeData!.topRadius),
              ),
            ),
          ),
          child:
              SafeArea(child: _configActionWidgets(context, _maxSheetHeight))),
      onVerticalDragUpdate: (v) => {},
    );

内容需包含:

1、运行环境

  • 运行设备
  • 系统
  • Bruno 版本
  • Flutter Doctor 信息

2、是否有与之关联的 issue

3、描述你期望的解决方案

4、附加信息

包括视频、图片等补充信息

@lvyandev lvyandev changed the title [Feature]: BrnCommonActionSheet的背景色应该可以配置 [Feature]: 大部分弹窗控件的背景色应该可以配置,而不是写死为白色 Oct 17, 2022
@zhoujuanjuan
Copy link
Collaborator

你好,感谢反馈,我们考虑把背景放到主题定制中

@zhoujuanjuan zhoujuanjuan self-assigned this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants