Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging updates #1486

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Logging updates #1486

merged 8 commits into from
Dec 12, 2024

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented Dec 6, 2024

Showing worker node with local comms can confuse users.

Only show worker node in the log when running in a distributed mode (e.g., MPI comms).

Also only report manager/worker initialization with debug logging.

This also adds a VDEBUG logging level for logging of communicating log messages, as this is rarely needed and is very verbose.

Removes unhelpful Uneven groups warning

@shuds13 shuds13 self-assigned this Dec 6, 2024
@shuds13 shuds13 changed the title Logging/update init output Update logging of worker initialization Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.95%. Comparing base (065134f) to head (eab18b3).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1486      +/-   ##
===========================================
+ Coverage    90.93%   90.95%   +0.02%     
===========================================
  Files           76       76              
  Lines         7678     7684       +6     
  Branches      1139     1140       +1     
===========================================
+ Hits          6982     6989       +7     
  Misses         534      534              
+ Partials       162      161       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shuds13 shuds13 requested review from jlnav and jmlarson1 December 6, 2024 22:18
@shuds13 shuds13 changed the title Update logging of worker initialization Logging updates Dec 6, 2024
@shuds13 shuds13 mentioned this pull request Dec 6, 2024
7 tasks
@shuds13 shuds13 merged commit e151c37 into develop Dec 12, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants