-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging updates #1486
Merged
Merged
Logging updates #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuds13
changed the title
Logging/update init output
Update logging of worker initialization
Dec 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1486 +/- ##
===========================================
+ Coverage 90.93% 90.95% +0.02%
===========================================
Files 76 76
Lines 7678 7684 +6
Branches 1139 1140 +1
===========================================
+ Hits 6982 6989 +7
Misses 534 534
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. |
jlnav
approved these changes
Dec 6, 2024
jmlarson1
reviewed
Dec 10, 2024
jmlarson1
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing worker node with local comms can confuse users.
Only show worker node in the log when running in a distributed mode (e.g., MPI comms).
Also only report manager/worker initialization with debug logging.
This also adds a
VDEBUG
logging level for logging of communicating log messages, as this is rarely needed and is very verbose.Removes unhelpful Uneven groups warning