Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark hash implementations #46

Open
acdha opened this issue Jun 15, 2018 · 1 comment
Open

Benchmark hash implementations #46

acdha opened this issue Jun 15, 2018 · 1 comment
Assignees

Comments

@acdha
Copy link
Member

acdha commented Jun 15, 2018

Currently we're using asmCrypto.js which has reasonable performance but we should compare with a WebAssembly implementation. Since Rust has an official WASM backend it should be relatively easy to use the SHA-2 crate and create a function which does exactly what we need (bytes -> hex) for benchmarking.

@acdha acdha self-assigned this Jun 15, 2018
acdha added a commit that referenced this issue Jun 15, 2018
These are small enough that we could use WebCrypto but that will require
dealing with a new API for encoding/decoding and producing a hex output
string. At the very least, this seems like it should wait until #46
since that could be a reasonable solution for both this need and hash
workers.

Closes #45
@acdha
Copy link
Member Author

acdha commented Aug 7, 2018

The WASM toolchain offers some interesting performance benefits but it definitely adds complexity:

e273bde

acdha/wasm-hashing@673e09b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant