Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapped-bivariate-to-array test fails #1

Open
Symbolics opened this issue Oct 2, 2019 · 0 comments
Open

wrapped-bivariate-to-array test fails #1

Symbolics opened this issue Oct 2, 2019 · 0 comments

Comments

@Symbolics
Copy link
Collaborator

This test fails under fiveam, but passes under clunit. Investigation shows that the two function results being compared:

(funcall op a b)
(funcall op (funcall convert a) b)

produce different results the first and second time being called. This leads to what appears to be a false negative in the test because the fiveam reason-arg, which is supposed to print a helpful diagnostic message, calls the functions a second time, producing correct results. The source code for the test contains experiments and debugging examples that demonstrate this.

The test code will not win any 'most readable code of the year' award, and the answer is buried below several layers of macro expansions, funcalls and currying. This one is not for beginners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant