Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

Conflicting documentation #142

Open
frank-fajardo-a142179 opened this issue Apr 17, 2021 · 0 comments
Open

Conflicting documentation #142

frank-fajardo-a142179 opened this issue Apr 17, 2021 · 0 comments

Comments

@frank-fajardo-a142179
Copy link

The README document says this when handling the error event:

If you receive a 401 error you should reconnect() according to the retry policy guidelines mentioned above, in the closed section.

However, this appear to conflict with the linked API Retry Policy Recommendations which says:

ERROR CODE MEANING RECOMMENDATION
4xx Client side error Do not retry, need to fix the problem in the code
429 Too many requests Retry after at least 1 second; avoid bursts of requests
5xx Error on server side Retry 3 times with 5, 10, 15 second pause between retries

So it implies we should NOT reconnect on 4xx, except for 429. So do NOT reconnect on HTTP 401.

Which one is correct?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant