fix: remove logging::bracket "*_view" overloads (#2919)

LizardByte · Jul 26, 2024 · 3691583 · 3691583
1 parent f4dda21
commit 3691583
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 28 deletions.
diff --git a/src/logging.cpp b/src/logging.cpp
@@ -172,22 +172,12 @@ namespace logging {
 
   std::string
   bracket(const std::string &input) {
-    return bracket(std::string_view(input));
-  }
-
-  std::string
-  bracket(const std::string_view &input) {
-    return "["s + std::string(input) + "]"s;
+    return "["s + input + "]"s;
   }
 
   std::wstring
   bracket(const std::wstring &input) {
-    return bracket(std::wstring_view(input));
-  }
-
-  std::wstring
-  bracket(const std::wstring_view &input) {
-    return L"["s + std::wstring(input) + L"]"s;
+    return L"["s + input + L"]"s;
   }
 
 }  // namespace logging
diff --git a/src/logging.h b/src/logging.h
@@ -212,14 +212,6 @@ namespace logging {
   std::string
   bracket(const std::string &input);
 
-  /**
-   * @brief Enclose string in square brackets.
-   * @param input Input string.
-   * @return Enclosed string.
-   */
-  std::string
-  bracket(const std::string_view &input);
-
   /**
    * @brief Enclose string in square brackets.
    * @param input Input string.
@@ -228,12 +220,4 @@ namespace logging {
   std::wstring
   bracket(const std::wstring &input);
 
-  /**
-   * @brief Enclose string in square brackets.
-   * @param input Input string.
-   * @return Enclosed string.
-   */
-  std::wstring
-  bracket(const std::wstring_view &input);
-
 }  // namespace logging