Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LICENSE from GPL v3 to AGPL v3 #150

Closed
wants to merge 1 commit into from
Closed

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 6, 2022

Description

Some commercial companies are utilizing modified versions of Sunshine without publishing the source code. Using GPL v3 could be argued that it's still distribution even though it's a network asset, as the end user has a high level of control over the virtual machine. Changing to the AGPL v3 license will remove any doubt.

The AGPL V3 license is a strong copyleft license that enforces open source on all components derived from any previous work. It closes the server-side loophole, where the source code isn’t made available if the software isn’t released. AGPL defines a user as anyone who accesses the server-side application if it is public-facing. For applications that reside inside the organization’s network, AGPL does not trigger the release of the source code.

https://snyk.io/learn/agpl-license/

This PR requires approval from previous contributors before being merged. Contributors tagged in this PR, please comment with "I approve" or "I reject"

Approval Tracking List

CPP contributors:

Non CPP contributors:

Contributors with un-merged changes (not in master branch yet):

In process PRs (not yet merged into any branch):

@ABeltramo
Copy link
Contributor

I approve

Will this change affect also the original Sunshine repo/source?

@exalented
Copy link
Contributor

I approve

@ReenigneArcher
Copy link
Member Author

Will this change affect also the original Sunshine repo/source?

No; however if everyone on this list agrees, it already encompasses all the original contributors so the change could be made to Loki's repo as well.

Also, this will only affect future releases, anything already released would remain under GPL v3.

@hadicharara
Copy link
Contributor

I approve !
Go free software!

@hadicharara
Copy link
Contributor

Btw which proprietary versions are we talking about?

@Logical-sh
Copy link
Contributor

I approve!

@ReenigneArcher
Copy link
Member Author

Btw which proprietary versions are we talking about?

This is the one that sparked this request: https://www.oneplay.in/
They have since published the source: https://github.com/astar10239/OPlayStreamingServer/tree/dev

Someone has speculated to me that this one is also using Sunshine: https://shrine.app/
I have no evidence to say that is true or not.

Then of course, there is Maximum settings: https://maximumsettings.com/
They have also published source code: https://github.com/Sean-MaximumSettings/Maxximizer-Sunshine

@psyke83
Copy link
Collaborator

psyke83 commented May 6, 2022

I approve.

@okkiv
Copy link
Contributor

okkiv commented May 6, 2022

I approve!

@arnerak
Copy link
Contributor

arnerak commented May 6, 2022

I approve

@gamozolabs
Copy link
Contributor

I approve!

@cgutman
Copy link
Collaborator

cgutman commented May 6, 2022

I approve

1 similar comment
@felipejfc
Copy link
Contributor

I approve

@theofficialgman
Copy link
Contributor

I approve.

@Doomsdayrs
Copy link
Contributor

How dare they profit off our work and give nothing back?

Parasites they be.

I approve!

@thatsysadmin
Copy link
Contributor

thatsysadmin commented May 6, 2022

I approve!

You have the OK from me!

@luk1337
Copy link
Contributor

luk1337 commented May 6, 2022

I approve!

2 similar comments
@sitiom
Copy link
Contributor

sitiom commented May 7, 2022

I approve!

@nowrep
Copy link
Contributor

nowrep commented May 7, 2022

I approve!

@KiralyCraft
Copy link
Contributor

While I approve, we must also look into how this affects linking against GPL libraries and other compatibility issues we may encounter down the road; Looks like linking a GPL thing against AGPL library doesn't work, though otherwise it should be fine - So full steam ahead

@angelnu
Copy link
Contributor

angelnu commented May 7, 2022

I approve

3 similar comments
@TheElixZammuto
Copy link
Contributor

I approve

@exetico
Copy link
Contributor

exetico commented May 7, 2022

I approve

@JacekJagosz
Copy link
Contributor

I approve

@sethicis
Copy link
Contributor

sethicis commented May 7, 2022

I approve 👍

@WisdomCode
Copy link
Contributor

I approve!

@hadogenes
Copy link

I approve

@diadatp
Copy link
Contributor

diadatp commented May 8, 2022

I approve.

@ReenigneArcher
Copy link
Member Author

While I approve, we must also look into how this affects linking against GPL libraries and other compatibility issues we may encounter down the road; Looks like linking a GPL thing against AGPL library doesn't work, though otherwise it should be fine - So full steam ahead

@KiralyCraft where did you find that linking GPL in an AGPL project isn't allowed? I've found it to be the opposite. I am not a license/legal expert though.

@KiralyCraft
Copy link
Contributor

May have gotten them reversed, although I did remember there was something to keep in mind regarding GPL; Oh well, looks like it's all good then, sorry

@Doomsdayrs
Copy link
Contributor

@loki-47-6F-64 has last been seen at https://github.com/Sude-/lgogdownloader/pull/224

Using a no-reply email
image

@Doomsdayrs
Copy link
Contributor

@PapyKahan Bonjour! I hope this message gets to you!

@Doomsdayrs
Copy link
Contributor

Doomsdayrs commented Mar 27, 2023

I have emailed @notentered once again, now using their personal email.

@ReenigneArcher
Copy link
Member Author

@Doomsdayrs thanks for your efforts in trying to reach the remaining contributors... much appreciated!

@Doomsdayrs
Copy link
Contributor

@Doomsdayrs thanks for your efforts in trying to reach the remaining contributors... much appreciated!

Trying my best, Freedom is a verb and I must act!

I have emailed @jorys-paulin with their personal email now.

@Doomsdayrs
Copy link
Contributor

If papy does not respond from ping, I will dig up their email too.

@LizardByte-bot
Copy link
Member

This PR is stale because it has been open for 90 days with no activity. Comment or remove the stale label, otherwise this will be closed in 10 days.

@PapyKahan
Copy link
Contributor

Hi everyone, I approve too. Sorry for being so far away since a long time.
Hope it helps you going forward.

@notentered
Copy link
Contributor

OMG. I've been not following for quite a while. Hope this is still ongoing and please excuse me for the quite laaaaate response.
I totally approve!

@Doomsdayrs
Copy link
Contributor

@jorys-paulin

Is the last traceable person

They have a twitter here, if anyone still has twitter they can try contacting them.
https://mobile.twitter.com/Jorys_Paulin

Their website is down since I last checked it
https://jorys-paulin.fr/

I sent them a message on crowdin
https://crowdin.com/profile/jorys_paulin

I'll later start digging their email out of git commits.

@mariotaku
Copy link
Contributor

mariotaku commented Sep 4, 2023

@Doomsdayrs That user jorys-paulin is one of the import helpers/moderators on the moonlight discord server. I'll forward this issue to the channel.

@Doomsdayrs
Copy link
Contributor

@Doomsdayrs That user jorys-paulin is one of the import helpers/moderators on the moonlight discord server. I'll forward this issue to the channel.

Oh that makes it much easier!

@Doomsdayrs
Copy link
Contributor

Finally, I'll contact the FSF on the situation with @loki-47-6F-64

@Doomsdayrs
Copy link
Contributor

@jorys-paulin does not approve, and I'm waiting on a reply from the fsf

@ReenigneArcher
Copy link
Member Author

@Doomsdayrs any word from FSF?

@Doomsdayrs
Copy link
Contributor

@Doomsdayrs any word from FSF?

What's your email, I'll forward you their response.

Excerpt:

... AGPLv3 and GPLv3 have a narrow compatibility set out in
their respective section 13. Which means that you can at least add
AGPLv3-licensed code to an otherwise GPLv3-licensed project. See:
https://www.gnu.org/licenses/license-list.en.html#AGPL
...

@ReenigneArcher
Copy link
Member Author

@Doomsdayrs are you on our LizardByte discord server?

@Danik1601
Copy link

Danik1601 commented Oct 19, 2023

I used this as a tip:

That user jorys-paulin is one of the import helpers/moderators on the moonlight discord server.

As a result I found not only jorys-paulin but also loki-47-6F-64 on that Discord server. I won't public links to their profiles here, but will DM them to @ReenigneArcher on Discord and @Doomsdayrs on Mastodon instead.

@Doomsdayrs
Copy link
Contributor

I used this as a tip:

That user jorys-paulin is one of the import helpers/moderators on the moonlight discord server.

As a result I found not only jorys-paulin but also loki-47-6F-64 on that Discord server. I won't public links to their profiles here, but will DM them to @ReenigneArcher on Discord and @Doomsdayrs on Mastodon instead.

I apologize, but this is already known.

Lokis discord account is dead, and jorys is hostile to the license change

@Danik1601
Copy link

I apologize, but this is already known.

Whops. Didn't mean to clutter your DMs, guys. Sorry.

jorys is hostile to the license change

That's sad to know.

Wish you best of luck anyway.

@mariotaku
Copy link
Contributor

While I agree with changing the license, I'd say that the way @Doomsdayrs contacts the contributors is questionable, rather than stating others are hostile to license change.

@Doomsdayrs
Copy link
Contributor

While I agree with changing the license, I'd say that the way @Doomsdayrs contacts the contributors is questionable, rather than stating others are hostile to license change.

I admit I was quite aggressive in finding the contributors, and I can see how it was unwanted by some. While some contributors were appreciative, as seen in this comment, I understand how others may not appreciate this approach. It wasn't my intention to come off as pushy or invasive, and it was my own frustration that made me judge Jorys position as hostile, which was incorrect.

Ultimately, my intent was solely to facilitate a smooth license transition for Sunshine and to unify all contributors in this decision. I genuinely meant no harm and I apologize for any unease I may have caused.

@ReenigneArcher
Copy link
Member Author

Thanks everyone for your efforts to get this license changed. Since this has been open for 1.5 years now and we were unable to get complete agreement, I will now be closing this. We came very close to a complete consensus, only missing 2 out of 80 total contributors. If either of the remaining two developers have a change of heart, please let me know and I will resume this activity.

P.S. There could potentially be a path forward with dual licensing, but that is not desirable path at this time. Maybe in the future we will reconsider. Thank you everyone!

@ReenigneArcher ReenigneArcher deleted the AGPL-license branch October 20, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.