Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chroma subsample position #1560

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Fix chroma subsample position #1560

merged 4 commits into from
Sep 6, 2023

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Aug 20, 2023

Description

It was offset because of missing shader constant buffer.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ns6089
Copy link
Contributor Author

ns6089 commented Sep 5, 2023

@cgutman Do you have any remaining concerns or things that would rather be done differently, no matter how minor? If not, maybe we can go forward with merging this.

@cgutman
Copy link
Collaborator

cgutman commented Sep 5, 2023

No, no concerns. I've been trying to merge it since yesterday, but random things kept stopping me. GH Actions would randomly fail or it would succeed then someone would merge something ahead of it.

@cgutman cgutman merged commit dad7bb4 into LizardByte:nightly Sep 6, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants