-
-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add port mapping table #1681
Conversation
|
7b1088a
to
52b4d18
Compare
Can you add a description or some emphasis on the HTTP port entry that indicates that's the one that should be provided to Moonlight when adding a PC manually? |
I would like to suggest to include an info that the Web UI Port does not have to (and should not) be forwarded. |
@cgutman yes, good idea. @yungleballz that will depend on user preferences. Many users forward it so they can modify settings away from home, or pair a new client. |
Idea: Add port checker -> https://www.npmjs.com/package/is-port-reachable This probably needs to be in a separate PR after webpack is implemented. |
I agree with yungle here, we need a big red scary warning to avoid people forwarding the UI without knowing what they do
Due to NAT (and hairpin), having Sunshine itself make the test is not representitive, the Internet Streaming Tool uses a relay server IIRC |
I wanted to add two columns.
|
52b4d18
to
75b22df
Compare
@cgutman This will appear if the user specifies a non default port. |
75b22df
to
d5bcefb
Compare
d5bcefb
to
ae7a9c4
Compare
ae7a9c4
to
4298961
Compare
Description
Add a port configuration table to the UI.
Also validates the config port is is in the range of 1029 to 65514, and that all ports are in the range of 1024 to 65535.
Modifies alerts to include a font awesome icon.
Screenshot
Default value:
Custom value:
Invalid values:
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.