Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for RTX HDR driver bug #2171

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Feb 24, 2024

Description

This reworks our dummy image handling to avoid triggering a driver bug with 551.61 drivers and RTX HDR enabled. It also provides a small performance improvement for that (uncommon) case of interacting with dummy image textures.

Screenshot

Issues Fixed or Closed

Fixes #2163

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@robbiered
Copy link

As a note, a temporary workaround for the repeat crashing is disable HDR in windows.

@ChrisBln2302
Copy link

Does this also fix the issue that HDR is not streamed properly when RTX-HDR is enabled for a game?

@ReenigneArcher ReenigneArcher added this to the adjust lint rules milestone Feb 28, 2024
Copy link

@RStanbouly RStanbouly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit is relatively minor, otherwise lgtm and it doesn't seem to be failing any checks.

src/platform/windows/display_vram.cpp Outdated Show resolved Hide resolved
As a side effect, it avoids useless allocations and uploads of
a zeroed memory buffer to clear the dummy image textures.
@cgutman cgutman force-pushed the rtx_hdr_workaround branch from 8c3b062 to 0e7c175 Compare March 1, 2024 06:08
@cgutman
Copy link
Collaborator Author

cgutman commented Mar 1, 2024

The minimal workaround turned out to not really be suitable as there were still some major stability issues with this texture upload codepath in the driver, even when it didn't crash by overreading our buffer (the event log was full of GPU error logs from nvlddmkm). I had to resort to a more complex fix, but it at least provides (small) performance benefits for all cases.

@cgutman cgutman merged commit 75a9788 into LizardByte:nightly Mar 1, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After enabling RTX HDR globally on 551.61 drivers, Sunshine cannot start.
5 participants