build(macos)!: add homebrew formula and drop dmg #2222
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -505,137 +505,96 @@ jobs: | |
| discussionCategory: announcements | ||
| prerelease: ${{ needs.setup_release.outputs.pre_release }} | ||
|
|
||
| build_mac_brew: | ||
| needs: [check_changelog, setup_release] | ||
| strategy: | ||
| fail-fast: false # false to test all, true to fail entire job if any fail | ||
| matrix: | ||
| include: | ||
| # https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories | ||
| # while GitHub has larger macOS runners, they are not available for our repos :( | ||
| - os_version: "12" | ||
| release: true | ||
| - os_version: "13" | ||
| - os_version: "14" | ||
| name: Homebrew (macOS-${{ matrix.os_version }}) | ||
| runs-on: macos-${{ matrix.os_version }} | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Dependencies Homebrew | ||
| run: | | ||
| # install dependencies using homebrew | ||
| brew install cmake | ||
|
|
||
| - name: Configure formula | ||
| run: | | ||
| # variables for formula | ||
| branch=${GITHUB_HEAD_REF} | ||
|
|
||
| # check the branch variable | ||
| if [ -z "$branch" ] | ||
| then | ||
| echo "This is a PUSH event" | ||
| clone_url=${{ github.event.repository.clone_url }} | ||
| branch="${{ github.ref_name }}" | ||
| else | ||
| echo "This is a PR event" | ||
| clone_url=${{ github.event.pull_request.head.repo.clone_url }} | ||
| branch="${{ github.event.pull_request.head.ref }}" | ||
| fi | ||
| echo "Branch: ${branch}" | ||
| echo "Clone URL: ${clone_url}" | ||
|
|
||
| mkdir build | ||
| cd build | ||
| cmake \ | ||
| -DGITHUB_BRANCH="${branch}" \ | ||
| -DGITHUB_CLONE_URL="${clone_url}" \ | ||
| -DSUNSHINE_CONFIGURE_HOMEBREW=ON \ | ||
| -DSUNSHINE_CONFIGURE_ONLY=ON \ | ||
| .. | ||
| cd .. | ||
|
|
||
| # copy formula to artifacts | ||
| mkdir -p homebrew | ||
| cp -f ./build/sunshine.rb ./homebrew/sunshine.rb | ||
|
|
||
| # testing | ||
| cat ./homebrew/sunshine.rb | ||
|
|
||
| - name: Upload Artifacts | ||
| if: ${{ matrix.release }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: sunshine-homebrew | ||
| path: homebrew/ | ||
|
|
||
| - name: Should Publish Homebrew Formula | ||
| id: homebrew_publish | ||
| run: | | ||
| PUBLISH=false | ||
| if [[ \ | ||
| "${{ matrix.release }}" == "true" && \ | ||
| "${{ github.repository_owner }}" == "LizardByte" && \ | ||
| "${{ needs.setup_release.outputs.create_release }}" == "true" && \ | ||
| "${{ github.ref }}" == "refs/heads/master" \ | ||
| ]]; then | ||
| PUBLISH=true | ||
| fi | ||
|
|
||
| echo "publish=${PUBLISH}" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Validate and Publish Homebrew Formula | ||
| uses: LizardByte/[email protected] | ||
| with: | ||
| formula_file: ${{ github.workspace }}/homebrew/sunshine.rb | ||
| git_email: ${{ secrets.GH_BOT_EMAIL }} | ||
| git_username: ${{ secrets.GH_BOT_NAME }} | ||
| publish: ${{ steps.homebrew_publish.outputs.publish }} | ||
| token: ${{ secrets.GH_BOT_TOKEN }} | ||
|
|
||
| build_mac_port: | ||
| needs: [check_changelog, setup_release] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| require "language/node" | ||
|
|
||
| class @PROJECT_NAME@ < Formula | ||
| desc "@PROJECT_DESCRIPTION@" | ||
| homepage "@PROJECT_HOMEPAGE_URL@" | ||
| url "@GITHUB_CLONE_URL@", | ||
| tag: "@GITHUB_BRANCH@" | ||
| version "@PROJECT_VERSION@" | ||
| license all_of: ["GPL-3.0-only"] | ||
| head "@GITHUB_CLONE_URL@", branch: "nightly" | ||
|
|
||
| depends_on "boost" => :build | ||
| depends_on "cmake" => :build | ||
| depends_on "pkg-config" => :build | ||
| depends_on "curl" | ||
| depends_on "miniupnpc" | ||
| depends_on "node" | ||
| depends_on "openssl" | ||
| depends_on "opus" | ||
ReenigneArcher marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| def install | ||
| args = %W[ | ||
| -DBUIld_WERROR=ON | ||
| -DCMAKE_INSTALL_PREFIX=#{prefix} | ||
| -DOPENSSL_ROOT_DIR=#{Formula["openssl"].opt_prefix} | ||
| -DSUNSHINE_ASSETS_DIR=sunshine/assets | ||
| -DSUNSHINE_BUILD_HOMEBREW=ON | ||
| ] | ||
| system "cmake", "-S", ".", "-B", "build", *std_cmake_args, *args | ||
|
|
||
| cd "build" do | ||
| system "make", "-j" | ||
| system "make", "install" | ||
| end | ||
| end | ||
|
|
||
| service do | ||
| run [opt_bin/"sunshine", "~/.config/sunshine/sunshine.conf"] | ||
| end | ||
|
|
||
| def caveats | ||
| <<~EOS | ||
| Thanks for installing @PROJECT_NAME@! | ||
|
|
||
| To get started, review the documentation at: | ||
| https://docs.lizardbyte.dev/projects/sunshine/en/latest/ | ||
|
|
||
| Sunshine can only access microphones on macOS due to system limitations. | ||
| To stream system audio use "Soundflower" or "BlackHole". | ||
|
|
||
| Gamepads are not currently supported on macOS. | ||
| EOS | ||
| end | ||
|
|
||
| test do | ||
| # test that the binary runs at all | ||
| output = shell_output("#{bin}/sunshine --version").strip | ||
| puts output | ||
|
|
||
| # TODO: add unit tests | ||
| end | ||
| end | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was modified to appease the homebrew audit step. The same complaints were presented by the Macports team previously, and I think the Flatpak team.