Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): break down config.html into smaller pieces #2491

Merged
merged 11 commits into from
May 13, 2024

Conversation

Hazer
Copy link
Member

@Hazer Hazer commented May 2, 2024

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@Hazer Hazer mentioned this pull request May 2, 2024
9 tasks
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

.gitignore Show resolved Hide resolved
src_assets/common/assets/web/PlatformLayout.vue Outdated Show resolved Hide resolved
src_assets/common/assets/web/PlatformLayout.vue Outdated Show resolved Hide resolved
src_assets/common/assets/web/PlatformLayout.vue Outdated Show resolved Hide resolved
src_assets/common/assets/web/public/assets/locale/en.json Outdated Show resolved Hide resolved
src_assets/common/assets/web/platform-i18n.js Outdated Show resolved Hide resolved
src_assets/common/assets/web/index.html Outdated Show resolved Hide resolved
@Hazer Hazer force-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823c Compare May 6, 2024 01:25
@Hazer Hazer requested a review from ReenigneArcher May 7, 2024 06:13
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

src_assets/common/assets/web/public/assets/locale/de.json Outdated Show resolved Hide resolved
src_assets/common/assets/web/platform-i18n.js Show resolved Hide resolved
src_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated Show resolved Hide resolved
src_assets/common/assets/web/PlatformLayout.vue Outdated Show resolved Hide resolved
src_assets/common/assets/web/configs/tabs/Advanced.vue Outdated Show resolved Hide resolved
@Hazer Hazer requested a review from ReenigneArcher May 12, 2024 20:45
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@            Coverage Diff            @@
##           nightly   #2491     +/-   ##
=========================================
  Coverage     6.94%   6.94%             
=========================================
  Files           87      87             
  Lines        17673   17673             
  Branches      8399    8399             
=========================================
  Hits          1227    1227             
- Misses       13717   15761   +2044     
+ Partials      2729     685   -2044     
Flag Coverage Δ
Linux 5.34% <ø> (ø)
Windows 2.56% <ø> (ø)
macOS-14 8.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

@Hazer
Copy link
Member Author

Hazer commented May 13, 2024

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer Hazer requested a review from ReenigneArcher May 13, 2024 14:23
Hazer and others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
@ReenigneArcher ReenigneArcher force-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4 Compare May 13, 2024 14:54
@ReenigneArcher ReenigneArcher merged commit 4b6ff37 into LizardByte:nightly May 13, 2024
49 of 53 checks passed
@Hazer Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@Hazer Hazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants