Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: optionally static link boost #2628

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jun 1, 2024

Description

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the build-optionally-static-link-boost branch from 9a0091c to d4dfca8 Compare June 1, 2024 20:19
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.88%. Comparing base (5f6fe33) to head (04f2775).
Report is 157 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2628      +/-   ##
=========================================
+ Coverage    9.86%   9.88%   +0.02%     
=========================================
  Files          88      88              
  Lines       18071   18070       -1     
  Branches     8605    8605              
=========================================
+ Hits         1782    1787       +5     
+ Misses      13466   13370      -96     
- Partials     2823    2913      +90     
Flag Coverage Δ
Linux 8.42% <ø> (ø)
Windows 3.78% <ø> (ø)
macOS-12 9.82% <ø> (+0.07%) ⬆️
macOS-13 9.73% <ø> (+0.07%) ⬆️
macOS-14 10.01% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build-optionally-static-link-boost branch 28 times, most recently from 52cc9c2 to 4120ec2 Compare June 7, 2024 22:29
@ReenigneArcher ReenigneArcher force-pushed the build-optionally-static-link-boost branch 19 times, most recently from a5acf49 to 083f9bc Compare June 14, 2024 01:29
@ReenigneArcher ReenigneArcher marked this pull request as ready for review June 14, 2024 01:30
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) June 14, 2024 01:33
@ReenigneArcher ReenigneArcher force-pushed the build-optionally-static-link-boost branch 3 times, most recently from 1b28d20 to 2c5326d Compare June 14, 2024 20:30
@ReenigneArcher ReenigneArcher force-pushed the build-optionally-static-link-boost branch from 2c5326d to 04f2775 Compare June 14, 2024 20:41
@ReenigneArcher ReenigneArcher merged commit ebc41ac into master Jun 14, 2024
48 checks passed
@ReenigneArcher ReenigneArcher deleted the build-optionally-static-link-boost branch June 14, 2024 21:37
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants