Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fedora): fix version variables and skip post on rpm-ostree #3265

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Oct 6, 2024

Description

Fix version number for copr build. Follow up for #3239.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.74%. Comparing base (15b91a1) to head (330a9d2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3265   +/-   ##
======================================
  Coverage    9.74%   9.74%           
======================================
  Files         101     101           
  Lines       17972   17972           
  Branches     8417    8417           
======================================
  Hits         1751    1751           
  Misses      13330   13330           
  Partials     2891    2891           
Flag Coverage Δ
Linux 7.27% <ø> (ø)
Windows 5.10% <ø> (ø)
macOS-13 10.54% <ø> (ø)
macOS-14 10.02% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the fix/fedora/version-variables branch from ecd5519 to b3fd6af Compare October 6, 2024 20:46
@ReenigneArcher ReenigneArcher changed the title build(fedora): fix version variables build(fedora): fix version variables and skip post on rpm-ostree Oct 6, 2024
@ReenigneArcher ReenigneArcher force-pushed the fix/fedora/version-variables branch 2 times, most recently from 6a05a3a to 888c83c Compare October 6, 2024 21:24
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) October 6, 2024 21:48
@ReenigneArcher ReenigneArcher force-pushed the fix/fedora/version-variables branch 15 times, most recently from d414782 to 83e4ebf Compare October 6, 2024 22:19
@ReenigneArcher ReenigneArcher force-pushed the fix/fedora/version-variables branch from 83e4ebf to 330a9d2 Compare October 6, 2024 22:35
Copy link

sonarcloud bot commented Oct 6, 2024

@ReenigneArcher ReenigneArcher merged commit 756d2e1 into master Oct 6, 2024
35 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/fedora/version-variables branch October 6, 2024 23:09
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant