Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chord regex #3

Open
eyaler opened this issue Mar 27, 2023 · 0 comments
Open

chord regex #3

eyaler opened this issue Mar 27, 2023 · 0 comments

Comments

@eyaler
Copy link

eyaler commented Mar 27, 2023

hi!

in:
pattern = "(\[ch\])([A-G]+)(\/[A-G]*[b#])*([(?m)|(?m\d)|(?b\d)|(?#\d)|(?maj\d)|(?add\d)|(?sus\d)|(?aug)|(?aug\d)|(?dim)|(?dim\d)]*)(\/[A-G]*[b#])*(\[\/ch\])"

i think the chord type part of the regex is wrong for several reasons:

  1. everything is in a charset [] so it is taken by the character treating the (, ), ?, |, etc as characters
  2. the (?...) syntax is wrong

it would still mostly work but can get in some noise

thanks for your awesome project. i am using your scraper here: https://github.com/eyaler/uku3le (now being reworked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant