No DevUpgradeImageAns when the FW upgrade image is not valid

[aajn]

Hi,

in v4.5.0, when FMP DevUpgradeImageReq is handled the DevUpgradeImageAns is only sent if the FW status is valid (UpImageStatus = 3). I think this is not in line with TS006-1.0.0 and the answer should be sent regardless of UpImageStatus. While the FW version should only be sent when UpImageStatus = 3.

This can be fixed by moving ctx->fmp_task_ctx_mask |= ANS_CMD_TASK_MASK; outside of the if

SWL2001/lbm_lib/smtc_modem_core/lorawan_packages/firmware_management_protocol/lorawan_fmp_package.c

Lines 717 to 733 in d05dad5

	if( ( ans_index + FMP_DEV_UPGRADE_IMAGE_ANS_SIZE ) <= max_payload_size )
	{
	ctx->fmp_tx_payload_ans[ans_index++] = FMP_DEV_UPGRADE_IMAGE_ANS;
	ctx->fmp_tx_payload_ans[ans_index++] = tmp_fw_status;
	if( tmp_fw_status == VALID_FIRMWARE_UPGRADE_IMAGE )
	{
	uint32_t next_fw_verion = smtc_modem_hal_get_next_fw_version_for_fuota( );
	ctx->fmp_tx_payload_ans[ans_index++] = next_fw_verion & 0xFF;
	ctx->fmp_tx_payload_ans[ans_index++] = ( next_fw_verion >> 8 ) & 0xFF;
	ctx->fmp_tx_payload_ans[ans_index++] = ( next_fw_verion >> 16 ) & 0xFF;
	ctx->fmp_tx_payload_ans[ans_index++] = ( next_fw_verion >> 24 ) & 0xFF;
	ctx->fmp_task_ctx_mask |= ANS_CMD_TASK_MASK;
	}
	}
	break;

[opeyrard]

Hi,
Thank you very much for your feedback.
Your remark is valid.
We will fix it in the next coming release.
Many thanks,