Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom handler while still supporting easy to use collector #21

Closed
GlenDC opened this issue Jan 28, 2024 · 0 comments · Fixed by #20
Closed

support custom handler while still supporting easy to use collector #21

GlenDC opened this issue Jan 28, 2024 · 0 comments · Fixed by #20

Comments

@GlenDC
Copy link
Contributor

GlenDC commented Jan 28, 2024

The enum Collector provided by this library is easy to use and works out of the box.
However it does not support any specialised custom handler logic that might be needed for some use cases.

This issue (feature request) flows out of #16. Turns out that the handler allows this kind of feature and more.
However I feel that adding that support to the collector directly overcomplicates stuff for the benefit of only some users (me).

So therefore I propose that the client instead works with a generic collector, so that by default one can still use
the Collector but can also implement their own if they wish any specialised handler logic (e.g. SSL modifications, header reads, byte tracking etc...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant