Multiple Fences Associate with ONE Event #1840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The game could set multiple fences completion at same event. But GFXR replay reset the event when a fence set completion at the event. It caused replay deadlock. Solution: Once fence set completion to a event, increase the event refcount. Once the event been triggered, gfxre decrease the refount. If the refcount is 0, means no fence waiting for the event, then fxre reset the event for next cycle.
|
CI gfxreconstruct build queued with queue ID 289345. |
|
CI gfxreconstruct build # 5214 running. |
|
CI gfxreconstruct build # 5214 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The game could set multiple fences completion at same event. But GFXR replay reset the event when a fence set completion at the event. It caused replay deadlock.
Solution:
Once fence set completion to a event, increase the event refcount. Once the event been triggered, GFXR decrease the refcount. If the refcount down to 0, means no fence waiting for the event, then GFXR reset the event for next cycle.