Do not keep asset file open #1863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 293303. |
|
CI gfxreconstruct build # 5276 running. |
|
CI gfxreconstruct build # 5276 failed. |
Closing the file can allow external users to keep track of when GFXR is done updating the file and therefore is safe to access it.
panos-lunarg
force-pushed
the
do_not_keep_asset_file_open
branch
from
1fa5cb9
to
572c2a9
Compare
|
CI gfxreconstruct build queued with queue ID 293376. |
|
CI gfxreconstruct build # 5277 running. |
|
CI gfxreconstruct build # 5277 passed. |
|
CI gfxreconstruct build queued with queue ID 296549. |
panos-lunarg
force-pushed
the
do_not_keep_asset_file_open
branch
from
dbaebba
to
4a04c85
Compare
|
CI gfxreconstruct build queued with queue ID 296563. |
|
CI gfxreconstruct build # 5304 running. |
|
CI gfxreconstruct build # 5304 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the file can allow external users to keep track of when GFXR is done updating the file and therefore is safe to access it.