Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If album is incorrect in lyrics file, the actual directory isn't shown on the website #519

Open
andy5995 opened this issue Dec 20, 2020 · 1 comment

Comments

@andy5995
Copy link
Contributor

If the album name is incorrect in lyrics file, the actual directory where the lyrics file resides isn't shown on the website

#518

image

I don't know if a test needs to be added or if the perpetrator who submits a PR that causes that must be more mindful... ;)

@snshn
Copy link
Member

snshn commented Dec 20, 2020

Had to deal with similar issues as well, very good point about potentially using tests for that.
The main problem here is the limitation of filesystems, e.g. Windows doesn't support question marks within file/directory names, that's why when the site gets built, it uses the album/artist/recording name from metadata. Maybe the test could ensure that if the length of album/artist/recording name is more than 4 characters, then at least 75% of the metadata value needs to match the fs name...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants