Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FindlibMesh.cmake to appropriately handle timpi libraries #111

Open
jdeaton opened this issue Nov 25, 2021 · 0 comments
Open

Fix FindlibMesh.cmake to appropriately handle timpi libraries #111

jdeaton opened this issue Nov 25, 2021 · 0 comments

Comments

@jdeaton
Copy link
Member

jdeaton commented Nov 25, 2021

While configuring GitHub Actions in this repository and attempting to get MAST to compile with both libMesh versions 1.5.1 and 1.6.2 I ran into issues related to handling of the timpi libraries. libMesh version 1.5.1 does not appear utilize timpi directly, whereas it is required for version 1.6.2.

It appears there is a workaround in the cmake/FindlibMesh.cmake file to assign the libMesh libraries to the timpi variables if timpi isn't found (as in the case of v1.5.1). I believe we can handle this better by detecting if libMesh version is >=1.6.0 and make them required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant