-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tarball size is very large for project size #103
Comments
Test files as in data files used as assets for testing? I know SciPy just went through a transition to use |
|
looking at the test files, there's just one traj which is large (8mb). (This is an actual TNG file from I think we could probably exclude this file from the tarball and run most but not all tests on a local installation. We could probably also not include any tests in the tarball, I'm not sure what the done thing is and if this is too aggressive. |
fwiw, this is the discussion that happened: scipy/scipy#15607 |
For pyedr we just lowered the file sizes to a reasonable limit and shipped that. I think the main thing would be whether or not you're expecting users to run tests on pytng post installation (i.e. if it's documented and/or you have a means of importing the datafiles that's user facing). If not you can probably just not include them or add them to MDAanlysisTests or MDAnalysisData instead? |
I don't think we expose running tests from an installation, so we could not include any in the tarball for now and cut a more svelte build without any drama. Then once/if we include some installation smoketests we can reinclude these. |
The pytng tarball is currently larger than the MDAnalysis tarball size (by roughly 3x).
The main source of this is the inclusion of test files as part of the tarball. I'm opening this issue to see if this is required / can be addressed in some way.
The text was updated successfully, but these errors were encountered: