Skip to content

Commit

Permalink
Merge pull request #70 from HDI-Project/issue_39_fix_install_document…
Browse files Browse the repository at this point in the history
…ation

Fix installation instructions. Also add contributor credits
  • Loading branch information
csala authored Jan 10, 2019
2 parents 97343c2 + 6d62e3c commit eb08f7c
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 24 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ docs/_build/
docs/mlprimitives.rst
docs/mlprimitives.*.rst
docs/modules.rst
docs/api

# PyBuilder
target/
Expand Down
11 changes: 10 additions & 1 deletion AUTHORS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,16 @@
Credits
=======

Development Lead
----------------

* Kalyan Veeramachaneni <[email protected]>
* Carles Sala <[email protected]>

Contributors
------------

* Carles Sala <[email protected]>
* Plamen Valentinov <[email protected]>
* Ihssan Tinawi <[email protected]>
* Max Kanter <[email protected]>
* Sze Nga Wong <[email protected]>
33 changes: 13 additions & 20 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,7 @@ Ready to contribute? Here's how to set up `MLPrimitives` for local development.

$ mkvirtualenv MLPrimitives
$ cd MLPrimitives/
$ pip install -e .
$ pip install -r requirements_dev.txt
$ make install-develop

4. Create a branch for local development::

Expand All @@ -142,11 +141,11 @@ Ready to contribute? Here's how to set up `MLPrimitives` for local development.
6. When you're done making changes, check that your changes pass flake8 and the
tests, including testing other Python versions with tox::

$ make test-all
$ make lint # Check code styling
$ make test-all # Execute tests on all python versions

7. Make also sure to include the necessary documentation in the code as docstrings following
the [google](https://google.github.io/styleguide/pyguide.html?showone=Comments#Comments)
or the [numpy](https://numpydoc.readthedocs.io/en/latest/format.html) docstring style.
the `google docstring`_ style.
If you want to view how your documentation will look like when it is published, you can
generate and view the docs with this command::

Expand All @@ -160,6 +159,8 @@ Ready to contribute? Here's how to set up `MLPrimitives` for local development.

9. Submit a pull request through the GitHub website.

.. _google docstring: https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html

Pull Request Guidelines
=======================

Expand Down Expand Up @@ -231,18 +232,10 @@ The process of releasing a new version involves several steps combining both ``g
development interation.

**Note:** Before starting the process, make sure that ``HISTORY.md`` has a section titled
**Unreleased** with the list of changes that will be included in the new version, and that
these changes are committed and available in ``master`` branch.
Normally this is just a list of the Pull Requests that have been merged since the latest version.

Once this is done, just run the following commands::

git checkout stable
git merge --no-ff master # This creates a merge commit
bumpversion release # This creates a new commit and a TAG
git push --tags origin stable
make release
git checkout master
git merge stable
bumpversion --no-tag patch
git push
after thew new version that is about to be released with the list of changes that will be
included in the new version, and that these changes are all committed and available in the
``master`` branch.
Normally this is just a list of the Issues that have been closed since the latest version.

Once this is done, just run the commands ``make release`` and insert the PyPi username and
password when required.
1 change: 0 additions & 1 deletion LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

5 changes: 3 additions & 2 deletions docs/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ To install MLPrimitives, run this command in your terminal:
$ pip install mlprimitives
This is the preferred method to install MLPrimitives, as it will always install the most recent stable release.
This is the preferred method to install MLPrimitives, as it will always install the most recent
stable release.

If you don't have `pip`_ installed, this `Python installation guide`_ can guide
you through the process.
Expand Down Expand Up @@ -44,7 +45,7 @@ Once you have a copy of the source, you can install it with:

.. code-block:: console
$ python setup.py install
$ make install-develop
.. _Github repo: https://github.com/HDI-Project/MLPrimitives
Expand Down

0 comments on commit eb08f7c

Please sign in to comment.