Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autorefill doesn't work with wheat seeds #24

Closed
thada2607 opened this issue Mar 24, 2020 · 9 comments
Closed

Autorefill doesn't work with wheat seeds #24

thada2607 opened this issue Mar 24, 2020 · 9 comments

Comments

@thada2607
Copy link

As the title said. I put all the wheat seeds in a slot to a composter and it didn't get refilled, I also threw it out and it didn't get refilled either.

@RoboMWM
Copy link
Member

RoboMWM commented Mar 24, 2020

This is probably a feature request then?

@RoboMWM RoboMWM added enhancement New feature or request and removed enhancement New feature or request labels Mar 24, 2020
@thada2607
Copy link
Author

This is probably a feature request then?

Isn't it an issue?

@RoboMWM
Copy link
Member

RoboMWM commented Mar 26, 2020

How is this an issue? Was this a feature that's broken?

@thada2607
Copy link
Author

How is this an issue? Was this a feature that's broken?

I'm confused, isn't the plugin's purpose to refill items in the hotbar regardless of whatever activity draining them?

@RoboMWM
Copy link
Member

RoboMWM commented Mar 26, 2020

isn't the plugin's purpose to refill items in the hotbar regardless of whatever activity draining them?

The plugin does not know how every item is used. It will refill tools. I'm not sure if disposable items are supposed to be refilled, but if so, it's probably because it's only looking at interact event - and I'm not sure if those items are accounted for. There isn't a "farming items" tag or anything of the sort, nor am I aware of there being such a feature.

Please note that I picked up this plugin, so feel free to point out in the plugin's description where this feature (or objective) is listed. If it's only implicit, I'll determine if it's part of the featureset.

@thada2607
Copy link
Author

I kinda see it. So where can I post my suggestions?

@RoboMWM
Copy link
Member

RoboMWM commented Mar 26, 2020

Here is fine, but note the readme

@thada2607
Copy link
Author

Here are my suggestions:

  1. Refills seeds (or any disposable items) after users spend it all to fill composters, also refills it when players throw it all out, the point is to make the plugin work with seeds (disposable items) like it would with any other items.
  2. Manually sorting by hotkeys (middle click or something).
    An implement of these would be appreciated. And thank you for your contribution.

@RoboMWM
Copy link
Member

RoboMWM commented Mar 27, 2020

make a separate issue for 2., and either revise or make another issue for 1.

@RoboMWM RoboMWM closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants